Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 253903002: SPDY - persist 300 most recently used servers that support SPDY to preferences file (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton, mmenke
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, jar (doing other things)
Visibility:
Public.

Description

SPDY - persist 300 most recently used servers that support SPDY to preferences file. This change reduces the size of Preferences file for around 3% of users who have lot of entries (some users have more than 10,000 entries). HttpServerProperties - Implement MRU for supports SPDY server list. Persist only the most recently used 300 entries. In memory keep all the entries. This change is similar to MRU change for AlternateProtocol. R=rch@chromium.org, mmenke@chromium.org BUG=258189 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267022

Patch Set 1 : Persist 300 MRU servers that support SPDY #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -56 lines) Patch
M chrome/browser/net/http_server_properties_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 6 chunks +8 lines, -12 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.h View 5 chunks +10 lines, -8 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 5 chunks +24 lines, -19 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 4 chunks +67 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ramant (doing other things)
6 years, 7 months ago (2014-04-28 23:34:44 UTC) #1
Ryan Hamilton
lgtm
6 years, 7 months ago (2014-04-29 18:13:37 UTC) #2
ramant (doing other things)
Hi Matt, Could you please review content/browser/loader, chrome/browser/net changes for OWNERS approval? It is surprising ...
6 years, 7 months ago (2014-04-29 18:26:59 UTC) #3
mmenke
On 2014/04/29 18:26:59, ramant wrote: > Hi Matt, > Could you please review content/browser/loader, chrome/browser/net ...
6 years, 7 months ago (2014-04-29 19:28:37 UTC) #4
ramant (doing other things)
On 2014/04/29 19:28:37, mmenke wrote: > On 2014/04/29 18:26:59, ramant wrote: > > Hi Matt, ...
6 years, 7 months ago (2014-04-29 19:30:41 UTC) #5
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 7 months ago (2014-04-29 19:30:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/253903002/120001
6 years, 7 months ago (2014-04-29 19:32:50 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 01:11:38 UTC) #8
Message was sent while issue was closed.
Change committed as 267022

Powered by Google App Engine
This is Rietveld 408576698