Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2539013002: [ic] Prevent KeyedStoreIC from being generic when storing doubles to integer typed arrays. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Prevent KeyedStoreIC from being generic when storing doubles to integer typed arrays. BUG=chromium:666947 Committed: https://crrev.com/c819616376b6835b61ff4f9e2667ba94ab25fe7f Cr-Commit-Position: refs/heads/master@{#41390}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Test fallback implementation of Float64RoundTiesEven #

Patch Set 3 : Always use Float64RoundTiesEven instruction when available #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -28 lines) Patch
M src/code-stub-assembler.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 2 6 chunks +135 lines, -27 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
Igor Sheludko
https://codereview.chromium.org/2539013002/diff/80001/src/code-stub-assembler.cc File src/code-stub-assembler.cc (left): https://codereview.chromium.org/2539013002/diff/80001/src/code-stub-assembler.cc#oldcode5404 src/code-stub-assembler.cc:5404: Node* CodeStubAssembler::ClampedToUint8(Node* int32_value) { I renamed it and moved ...
4 years ago (2016-11-30 09:32:05 UTC) #9
Jakob Kummerow
lgtm
4 years ago (2016-11-30 10:30:37 UTC) #12
Jakob Kummerow
patch set 3 LGTM.
4 years ago (2016-11-30 14:56:19 UTC) #17
epertoso
lgtm for compiler/
4 years ago (2016-11-30 15:04:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539013002/140001
4 years ago (2016-11-30 15:22:12 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:140001)
4 years ago (2016-11-30 15:24:05 UTC) #26
commit-bot: I haz the power
4 years ago (2016-11-30 15:24:29 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c819616376b6835b61ff4f9e2667ba94ab25fe7f
Cr-Commit-Position: refs/heads/master@{#41390}

Powered by Google App Engine
This is Rietveld 408576698