Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 2538983002: Made CSS white-space property use IndependentInherit (Closed)

Created:
3 years, 8 months ago by napper
Modified:
3 years, 8 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis, meade_UTC10, esprehn, rune
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made CSS white-space property use IndependentInherit Made CSS white-space property use IndependentInherit, which is part of the process of making property inheritance faster. This change adds 1 bit to the size of ComputedStyle but significantly reduces the time for a recalc for independent-only changes involving whitespace. Tested using: third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html BUG=622138 Committed: https://crrev.com/bd928558b52c794c649fc064a82151bd9171ee65 Cr-Commit-Position: refs/heads/master@{#435559}

Patch Set 1 #

Patch Set 2 : Updated independent-inheritance-fast-path test to include white-space property #

Patch Set 3 : cl format third_party/WebKit #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 5 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (20 generated)
napper
3 years, 8 months ago (2016-12-01 02:29:23 UTC) #13
sashab
big fat LGTM!! \o/!!!!!! +cc eddy, rune and elliott who will be happy to see ...
3 years, 8 months ago (2016-12-01 02:45:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538983002/60001
3 years, 8 months ago (2016-12-01 03:55:45 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 8 months ago (2016-12-01 05:14:59 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2016-12-01 05:20:16 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bd928558b52c794c649fc064a82151bd9171ee65
Cr-Commit-Position: refs/heads/master@{#435559}

Powered by Google App Engine
This is Rietveld 408576698