Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2538903003: [GN] Fix tools/gn/bootstrap/bootstrap.py. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Fix tools/gn/bootstrap/bootstrap.py. Update the list of files required to boostrap gn (best-effort). Tested that gn is build successfully on macOS. BUG=None Committed: https://crrev.com/eace899f8a53284c3618940122caa858c03c602c Cr-Commit-Position: refs/heads/master@{#435273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-11-30 15:41:32 UTC) #4
Nico
lgtm
4 years ago (2016-11-30 15:52:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538903003/1
4 years ago (2016-11-30 15:53:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 16:01:16 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eace899f8a53284c3618940122caa858c03c602c Cr-Commit-Position: refs/heads/master@{#435273}
4 years ago (2016-11-30 16:04:36 UTC) #14
Dirk Pranke
4 years ago (2016-12-01 00:06:17 UTC) #15
Message was sent while issue was closed.
lgtm also.

Powered by Google App Engine
This is Rietveld 408576698