[DocServer] Updated Top Sites Sample Extension.

chrome/common/extensions/docs/examples/api/topsites/basic/popup.js

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[not at google - send to devlin, 2013/10/01 15:04:36]

it would be nice if this file were detected as a move from the other one (there
is some "git cl upload" flag to set similarity). if not (i.e. if it doesn't make
sense), then update this copyright year.

[François Beaufort, 2013/10/02 12:44:59]

I've played as much as possible with "git cl upload --similarity" and it never
worked as intended.
I really wish "git mv" would be considered but it's not ;(

So I ended up updating the Copyright year.


On 2013/10/01 15:04:36, kalman wrote:

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Event listener for clicks on links in a browser action popup.
+// Open the link in a new tab of the current window.
+function onAnchorClick(event) {
+  chrome.tabs.create({ url: event.srcElement.href });
+  return false;
+}
+
+// Given an array of URLs, build a DOM list of these URLs in the
+// browser action popup.
+function buildPopupDom(data) {

[not at google - send to devlin, 2013/10/01 15:04:36]

s/data/historyItems/

[François Beaufort, 2013/10/02 12:44:59]

Done.

+  var popupDiv = document.getElementById("mostVisited_div");
+
+  var ol = document.createElement('ol');
+  popupDiv.appendChild(ol);
+
+  for (var i = 0; i < data.length; i++) {
+    var a = document.createElement('a');
+    a.href = data[i].url;
+    a.appendChild(document.createTextNode(data[i].title));
+    a.addEventListener('click', onAnchorClick);
+
+    var li = document.createElement('li');
+    li.appendChild(a);
+
+    ol.appendChild(li);

[not at google - send to devlin, 2013/10/01 15:04:36]

i'm gonna nitpick here for no other reason than DOM API verbosity irritates me.
appendChild(...) returns the appended child, so you can write slightly more
concise code like:

for (...) {
  var li = ol.appendChild(document.createElement('li'));
  var a = li.appendChild(document.createElement('a'));
  ...
}

+  }
+}
+
+chrome.topSites.get(function(historyItems) {
+  buildPopupDom(historyItems);
+});

[not at google - send to devlin, 2013/10/01 15:04:36]

cleanup: chrome.topSites.get(buildPopupDom);