chrome/common/extensions/docs/examples/api/topsites/basic/manifest.json - Issue 25389003: [DocServer] Updated Top Sites Sample Extension.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/examples/api/topsites/basic/manifest.json

Issue 25389003: [DocServer] Updated Top Sites Sample Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "Top Sites",

	3 "version": "1.2",

	4 "description": "Shows the top sites in a browser action",

	5 "permissions": ["topSites"],

	6 "browser_action": {

	7 "default_popup": "popup.html"
	not at google - send to devlin 2013/10/01 15:04:36 there was an icon for the old extension, could you there was an icon for the old extension, could you include that? François Beaufort 2013/10/02 12:44:59 The old icon is actually not a valid file as you c The old icon is actually not a valid file as you can see at http://src.chromium.org/svn/trunk/src/chrome/common/extensions/docs/examples/... On 2013/10/01 15:04:36, kalman wrote: Show quoted text > there was an icon for the old extension, could you include that? not at google - send to devlin 2013/10/02 14:48:12 Ah, oops... I would suggest finding an appropriate Show quoted text On 2013/10/02 12:44:59, François Beaufort wrote: > The old icon is actually not a valid file as you can see at > http://src.chromium.org/svn/trunk/src/chrome/common/extensions/docs/examples/... > > On 2013/10/01 15:04:36, kalman wrote: > > there was an icon for the old extension, could you include that? > Ah, oops... I would suggest finding an appropriate icon somewhere in the chrome repo but it hardly seems worth it.
	8 },

	9 "manifest_version": 2

	10 }

OLD	NEW