Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: media/remoting/remote_renderer_impl.h

Issue 2538853002: Media Remoting: Draw remoting interstitial on poster image. (Closed)
Patch Set: Use base::<Optional> to tell that the background is unchanged. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/remoting/remote_renderer_impl.h
diff --git a/media/remoting/remote_renderer_impl.h b/media/remoting/remote_renderer_impl.h
index 38947f94a61ad222d1d9ecc2eb4ec24471350206..64a6e1d1d9740a0f0feb565788daa29d3c9d4fe1 100644
--- a/media/remoting/remote_renderer_impl.h
+++ b/media/remoting/remote_renderer_impl.h
@@ -13,6 +13,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
+#include "base/optional.h"
#include "base/synchronization/lock.h"
#include "media/base/buffering_state.h"
#include "media/base/pipeline_status.h"
@@ -72,7 +73,7 @@ class RemoteRendererImpl : public Renderer {
static void RequestUpdateInterstitialOnMainThread(
scoped_refptr<base::SingleThreadTaskRunner> media_task_runner,
base::WeakPtr<RemoteRendererImpl> remote_renderer_impl,
- const SkBitmap& background_image,
+ const base::Optional<SkBitmap>& background_image,
const gfx::Size& canvas_size,
RemotingInterstitialType interstitial_type);
@@ -130,10 +131,9 @@ class RemoteRendererImpl : public Renderer {
void OnStatisticsUpdate(std::unique_ptr<remoting::pb::RpcMessage> message);
void OnDurationChange(std::unique_ptr<remoting::pb::RpcMessage> message);
- // Called to update the remoting interstitial. Draw remoting interstitial on
- // |interstitial_background_| if |background_image| is empty. Update
- // |interstitial_background_| if |background_image| is not empty.
- void UpdateInterstitial(const SkBitmap& background_image,
+ // Called to update the remoting interstitial. Update
+ // |interstitial_background_| if |background_image| is set.
+ void UpdateInterstitial(const base::Optional<SkBitmap>& background_image,
const gfx::Size& canvas_size,
RemotingInterstitialType interstitial_type);

Powered by Google App Engine
This is Rietveld 408576698