content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc - Issue 2538853002: Media Remoting: Draw remoting interstitial on poster image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

Issue 2538853002: Media Remoting: Draw remoting interstitial on poster image. (Closed)

Patch Set: Addressed xhwang's comment. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/fetchers/multi_resolution_image_resource_fetcher.h ('k') | content/renderer/image_downloader/image_downloader_base.h » ('j') | content/renderer/image_downloader/single_image_downloader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

diff --git a/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc b/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

index 3e42b86ef3b869033d505956f87b8eb93cecc7dc..5dda475db1f42c5f017d6084d8066e60420c6674 100644

--- a/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

+++ b/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

@@ -81,4 +81,11 @@ void MultiResolutionImageResourceFetcher::OnURLFetchComplete(

callback.Run(this, bitmaps);

}

+void MultiResolutionImageResourceFetcher::OnRenderFrameDestruct() {

miu 2016/12/20 00:48:06 Nice! I like this solution much better. :)

xjz 2016/12/20 21:46:25 Thanks. :)

+ // Take a reference to the callback as running the callback may lead to our

+ // destruction.

+ Callback callback = callback_;

+ callback.Run(this, std::vector<SkBitmap>());

} // namespace content