Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: media/remoting/remoting_renderer_controller.h

Issue 2538853002: Media Remoting: Draw remoting interstitial on poster image. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/remoting/remoting_renderer_controller.h
diff --git a/media/remoting/remoting_renderer_controller.h b/media/remoting/remoting_renderer_controller.h
index 9c98af12b555441c1ade86ff34291b321c7a8076..4a76387cd019c41336671fe28250b991f7719f95 100644
--- a/media/remoting/remoting_renderer_controller.h
+++ b/media/remoting/remoting_renderer_controller.h
@@ -9,6 +9,7 @@
#include "base/memory/weak_ptr.h"
#include "media/base/media_observer.h"
#include "media/remoting/remoting_source_impl.h"
+#include "third_party/skia/include/core/SkBitmap.h"
namespace media {
@@ -37,9 +38,15 @@ class RemotingRendererController final : public RemotingSourceImpl::Client,
void OnExitedFullscreen() override;
void OnSetCdm(CdmContext* cdm_context) override;
void OnMetadataChanged(const PipelineMetadata& metadata) override;
+ void OnSetPoster(const GURL& poster) override;
void SetSwitchRendererCallback(const base::Closure& cb);
+ using PosterDownloadedCallback = base::Callback<void(const SkBitmap& bitmap)>;
+ using DownloadPosterCallback =
+ base::Callback<void(const GURL& url, const PosterDownloadedCallback& cb)>;
+ void SetDownloadPosterCallback(const DownloadPosterCallback& cb);
+
base::WeakPtr<RemotingRendererController> GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
@@ -69,6 +76,16 @@ class RemotingRendererController final : public RemotingSourceImpl::Client,
return pipeline_metadata_;
}
+ GURL poster() const {
miu 2016/11/29 22:56:09 Rather than exposing poster() and download_poster_
xjz 2016/12/02 19:23:11 Done.
+ DCHECK(thread_checker_.CalledOnValidThread());
+ return poster_;
+ }
+
+ DownloadPosterCallback download_poster_cb() const {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ return download_poster_cb_;
+ }
+
private:
bool has_audio() const {
return pipeline_metadata_.has_audio &&
@@ -116,6 +133,10 @@ class RemotingRendererController final : public RemotingSourceImpl::Client,
PipelineMetadata pipeline_metadata_;
+ GURL poster_;
+
+ DownloadPosterCallback download_poster_cb_;
+
base::WeakPtrFactory<RemotingRendererController> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RemotingRendererController);

Powered by Google App Engine
This is Rietveld 408576698