Media Remoting: Draw remoting interstitial on poster image.

content/renderer/image_downloader/image_downloader_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/image_downloader/image_downloader_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 103 matching lines @@
     return;
   images->push_back(resized);
   original_image_sizes->push_back(
       gfx::Size(min_image->width(), min_image->height()));
 }
 
 }  // namespace
 
 namespace content {
 
 ImageDownloaderImpl::ImageDownloaderImpl(

[miu, 2016/11/29 22:56:08]

Factoring: This other constructor should delegate to your new ctor, rather that
repeat the common initialization. Meaning:

  ImageDownloaderImpl::ImageDownloaderImpl(...)
    : ImageDownloaderImpl(render_frame) {
    binding_.Bind(request);
    binding_.set_connection_error_handler(...);
  }

[xjz, 2016/12/02 19:23:10]

Not applicable.

     RenderFrame* render_frame,
     mojom::ImageDownloaderRequest request)
     : RenderFrameObserver(render_frame),
       binding_(this, std::move(request)) {
   DCHECK(render_frame);
   RenderThread::Get()->AddObserver(this);
   binding_.set_connection_error_handler(
       base::Bind(&ImageDownloaderImpl::OnDestruct, base::Unretained(this)));
 }
 
+ImageDownloaderImpl::ImageDownloaderImpl(RenderFrame* render_frame)
+    : RenderFrameObserver(render_frame), binding_(this) {
+  DCHECK(render_frame);
+  RenderThread::Get()->AddObserver(this);
+}
+
 ImageDownloaderImpl::~ImageDownloaderImpl() {
   RenderThread* thread = RenderThread::Get();
   // As ImageDownloaderImpl is a strong binding with message pipe, the
   // destructor may run after message loop shutdown, so we need to check whether
   // RenderThread is null.
   if (thread)
     thread->RemoveObserver(this);
 }
 
 // static
@@ skipping 89 matching lines @@
     const std::vector<gfx::Size>& result_original_image_sizes,
     const DownloadImageCallback& callback) {
   callback.Run(http_status_code, result_images, result_original_image_sizes);
 }
 
 void ImageDownloaderImpl::OnDestruct() {
   delete this;
 }
 
 }  // namespace content