Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2538833005: [scheduler] Add options to TaskQueue::InsertFence (Closed)

Created:
4 years ago by altimin
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[scheduler] Add options to TaskQueue::InsertFence Make TaskQueue::InsertFence configurable and allow to insert a fence in the beginning for the TaskQueue, effectively disabling it. It will allow TaskQueueThrottler to use only fences without disabling and enabling queues. R=alexclarke@chromium.org,skyostil@chromium.org BUG=638542 Review-Url: https://codereview.chromium.org/2533603002 Cr-Commit-Position: refs/heads/master@{#434542} (cherry picked from commit d15597b8f924879440a66ef0f12f9a939b7c30ea) Committed: https://chromium.googlesource.com/chromium/src/+/6abf248fbb96094a0ee7c103840eeccb23b38a31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -253 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/enqueue_order.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/enqueue_order.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue.cc View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 2 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 9 chunks +42 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 6 chunks +23 lines, -119 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/base/task_queue.h View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
altimin
Committed patchset #1 (id:1) manually as 6abf248fbb96094a0ee7c103840eeccb23b38a31.
4 years ago (2016-12-01 15:02:51 UTC) #2
alex clarke (OOO till 29th)
4 years ago (2016-12-01 15:07:11 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698