Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 253883006: Missing machine model info should be a no match for GPU blacklist (Closed)

Created:
6 years, 7 months ago by Zhenyao Mo
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Missing machine model info should be a no match for GPU blacklist BUG=368006 TEST=gpu_unittests, on win/linux, gpu_rasterization is off R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266963

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M gpu/config/gpu_control_list.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/config/gpu_control_list_entry_unittest.cc View 2 chunks +79 lines, -0 lines 0 comments Download
M gpu/config/software_rendering_list_json.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Zhenyao Mo
kbr: please take a look. (This will turn off gpu_rasterization on Linux/Windows) reveman: FYI
6 years, 7 months ago (2014-04-28 22:19:17 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 7 months ago (2014-04-28 23:32:23 UTC) #2
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 7 months ago (2014-04-29 00:14:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/253883006/20001
6 years, 7 months ago (2014-04-29 00:17:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 01:03:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 01:03:39 UTC) #6
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 7 months ago (2014-04-29 01:27:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/253883006/20001
6 years, 7 months ago (2014-04-29 01:28:29 UTC) #8
Ken Russell (switch to Gerrit)
On 2014/04/29 01:03:39, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-04-29 01:29:02 UTC) #9
Zhenyao Mo
On 2014/04/29 01:29:02, Ken Russell wrote: > On 2014/04/29 01:03:39, I haz the power (commit-bot) ...
6 years, 7 months ago (2014-04-29 01:35:51 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 02:11:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 02:11:45 UTC) #12
Zhenyao Mo
I don't think the mac_gpu bots failures are related. Landing manually.
6 years, 7 months ago (2014-04-29 16:44:42 UTC) #13
Ken Russell (switch to Gerrit)
On 2014/04/29 16:44:42, Zhenyao Mo wrote: > I don't think the mac_gpu bots failures are ...
6 years, 7 months ago (2014-04-29 18:34:48 UTC) #14
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 7 months ago (2014-04-29 19:22:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/253883006/20001
6 years, 7 months ago (2014-04-29 19:23:39 UTC) #16
alokp
6 years, 7 months ago (2014-04-29 21:22:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 manually as r266963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698