Eliminates the use of VideoCaptureDevice1 in VideoCaptureDeviceLinux.

Eliminates the use of VideoCaptureDevice1 in VideoCaptureDeviceLinux.

BUG=297854
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226496

[jiayl, 2013-09-30 23:22:58]

PTAL. Thanks!

[ncarter (slow), 2013-10-01 20:45:23]

lgtm with one comment.

+fischman for OWNERS

https://codereview.chromium.org/25388002/diff/7001/media/video/capture/linux/...
File media/video/capture/linux/video_capture_device_linux.cc (right):

https://codereview.chromium.org/25388002/diff/7001/media/video/capture/linux/...
media/video/capture/linux/video_capture_device_linux.cc:539:
DCHECK_EQ(v4l2_thread_.message_loop(), base::MessageLoop::current());
The "theoretical" cleanup call to DeAllocateVideoBuffers() on line  248 could
"theoretically" get here, on the device thread.

Either this DCHECK or the call on line 248 should go away. My preference would
be to leave the DCHECK remove the call -- I don't think it serves any purpose --
but it's possible I missed some subtlety?

[Ami GONE FROM CHROMIUM, 2013-10-01 21:17:27]

LGTM

https://codereview.chromium.org/25388002/diff/7001/media/video/capture/linux/...
File media/video/capture/linux/video_capture_device_linux.cc (right):

https://codereview.chromium.org/25388002/diff/7001/media/video/capture/linux/...
media/video/capture/linux/video_capture_device_linux.cc:539:
DCHECK_EQ(v4l2_thread_.message_loop(), base::MessageLoop::current());
On 2013/10/01 20:45:23, ncarter wrote:
> The "theoretical" cleanup call to DeAllocateVideoBuffers() on line  248 could
> "theoretically" get here, on the device thread.
> 
> Either this DCHECK or the call on line 248 should go away. My preference would
> be to leave the DCHECK remove the call -- I don't think it serves any purpose
--
> but it's possible I missed some subtlety?

I think line 380 is the reason for the "(theoretically)", and I don't think we
can drop that unless we restructure cleanup.

I think the minimal change that makes this correct is to DCHECK that either
we're on the v4l2 thread here _or_ that the v4l2 thread is stopped.

[jiayl, 2013-10-01 21:34:17]

Thanks!

https://codereview.chromium.org/25388002/diff/7001/media/video/capture/linux/...
File media/video/capture/linux/video_capture_device_linux.cc (right):

https://codereview.chromium.org/25388002/diff/7001/media/video/capture/linux/...
media/video/capture/linux/video_capture_device_linux.cc:539:
DCHECK_EQ(v4l2_thread_.message_loop(), base::MessageLoop::current());
On 2013/10/01 21:17:27, Ami Fischman wrote:
> On 2013/10/01 20:45:23, ncarter wrote:
> > The "theoretical" cleanup call to DeAllocateVideoBuffers() on line  248
could
> > "theoretically" get here, on the device thread.
> > 
> > Either this DCHECK or the call on line 248 should go away. My preference
would
> > be to leave the DCHECK remove the call -- I don't think it serves any
purpose
> --
> > but it's possible I missed some subtlety?
> 
> I think line 380 is the reason for the "(theoretically)", and I don't think we
> can drop that unless we restructure cleanup.
> 
> I think the minimal change that makes this correct is to DCHECK that either
> we're on the v4l2 thread here _or_ that the v4l2 thread is stopped.

Done.

[commit-bot: I haz the power, 2013-10-01 23:07:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiayl@chromium.org/25388002/14001

[commit-bot: I haz the power, 2013-10-02 00:04:21]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 00:11:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiayl@chromium.org/25388002/14001

[commit-bot: I haz the power, 2013-10-02 00:52:22]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 16:32:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiayl@chromium.org/25388002/14001

[commit-bot: I haz the power, 2013-10-02 17:53:31]

Change committed as 226496