Log audio system used to WebRTC log.

Log audio system used to WebRTC log.

This is interesting on for example Linux, where we fallback on ALSA if PulseAudio fails to initialize.

* Add AudioManager::GetName() and implementations in sub-classes.
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/12d3f1b37dbe91316f5c3ce2bfc006204458fe8d
Cr-Commit-Position: refs/heads/master@{#435923}

[Henrik Grunell, 2016-11-29 17:28:38]

Description was changed from

==========
Log audio system used on Linux to WebRTC log.

* Add AudioManager::GetAudioSystemName() for Linux builds (PulseAudio, ALSA,
CRAS).
* Log it to WebRTC log.

BUG=
==========

to

==========
Log audio system used on Linux to WebRTC log.

* Add AudioManager::GetAudioSystemName() for Linux builds (PulseAudio, ALSA,
CRAS).
* Log it to WebRTC log.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Henrik Grunell, 2016-11-30 09:29:11]

Patchset #1 (id:1) has been deleted

[Henrik Grunell, 2016-11-30 09:31:11]

Description was changed from

==========
Log audio system used on Linux to WebRTC log.

* Add AudioManager::GetAudioSystemName() for Linux builds (PulseAudio, ALSA,
CRAS).
* Log it to WebRTC log.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Log audio system used on Linux to WebRTC log.

* Add AudioManager::GetAudioSystemName() for Linux builds (PulseAudio, ALSA,
CRAS).
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Henrik Grunell, 2016-11-30 09:31:11]

grunell@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Henrik Grunell, 2016-11-30 09:37:35]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 09:37:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 09:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 09:54:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Henrik Grunell, 2016-11-30 16:27:58]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 16:28:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 16:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 16:48:32]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[DaleCurtis, 2016-11-30 22:12:12]

Maybe just have an AudioManager::GetName() method for all implementations? That
allows us to avoid any special platform specific #ifdefs.

[Henrik Grunell, 2016-12-01 15:44:10]

Description was changed from

==========
Log audio system used on Linux to WebRTC log.

* Add AudioManager::GetAudioSystemName() for Linux builds (PulseAudio, ALSA,
CRAS).
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Log audio system used to WebRTC log.

This is interesting on for example Linux, where we fallback on ALSA if
PulseAudio fails to initialize.

* Add AudioManager::GetName() and implementations in sub-classes.
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Henrik Grunell, 2016-12-01 15:44:10]

grunell@chromium.org changed reviewers:
+ alokp@chromium.org

[Henrik Grunell, 2016-12-01 15:47:24]

Yes, I considered implementing it for all platforms but leaned towards Linux
only where it should only be of interest. (To save some strings and code.) But
I'm fine with an all-platform approach, that has its advantages too, I've
changed to that.

Adding alokp@ for chromecast/

[Henrik Grunell, 2016-12-01 15:53:28]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 15:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 17:23:39]

Dry run: This issue passed the CQ dry run.

[alokp, 2016-12-01 17:32:46]

chromecast/ lgtm

[DaleCurtis, 2016-12-01 17:49:38]

lgtm % inlining the constant; have two places to look for something like this is
more pain than  clarity.

https://codereview.chromium.org/2538793002/diff/60001/chromecast/media/audio/...
File chromecast/media/audio/cast_audio_manager.cc (right):

https://codereview.chromium.org/2538793002/diff/60001/chromecast/media/audio/...
chromecast/media/audio/cast_audio_manager.cc:26: const char kAudioManagerName[]
= "Cast";
If there's only a single user of this it's generally preferable to inline it
into the return statement.

[Henrik Grunell, 2016-12-02 08:40:27]

https://codereview.chromium.org/2538793002/diff/60001/chromecast/media/audio/...
File chromecast/media/audio/cast_audio_manager.cc (right):

https://codereview.chromium.org/2538793002/diff/60001/chromecast/media/audio/...
chromecast/media/audio/cast_audio_manager.cc:26: const char kAudioManagerName[]
= "Cast";
On 2016/12/01 17:49:38, DaleCurtis wrote:
> If there's only a single user of this it's generally preferable to inline it
> into the return statement.

Done.

[Henrik Grunell, 2016-12-02 08:40:39]

The CQ bit was checked by grunell@chromium.org

[Henrik Grunell, 2016-12-02 08:40:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2538793002/#ps80001
(title: "Code review.")

[commit-bot: I haz the power, 2016-12-02 08:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 12:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480668039707870,
"parent_rev": "de444907e9e26abeefc935435625dad688539fe9", "commit_rev":
"c89fdf9bf89407560852e44fd3893c2721c01589"}

[commit-bot: I haz the power, 2016-12-02 12:28:42]

Description was changed from

==========
Log audio system used to WebRTC log.

This is interesting on for example Linux, where we fallback on ALSA if
PulseAudio fails to initialize.

* Add AudioManager::GetName() and implementations in sub-classes.
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Log audio system used to WebRTC log.

This is interesting on for example Linux, where we fallback on ALSA if
PulseAudio fails to initialize.

* Add AudioManager::GetName() and implementations in sub-classes.
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-02 12:28:43]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-02 12:31:42]

Description was changed from

==========
Log audio system used to WebRTC log.

This is interesting on for example Linux, where we fallback on ALSA if
PulseAudio fails to initialize.

* Add AudioManager::GetName() and implementations in sub-classes.
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Log audio system used to WebRTC log.

This is interesting on for example Linux, where we fallback on ALSA if
PulseAudio fails to initialize.

* Add AudioManager::GetName() and implementations in sub-classes.
* Log it to WebRTC log in WebRtcTextLogHandler::LogInitialInfoOnIOThread().

BUG=669510

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/12d3f1b37dbe91316f5c3ce2bfc006204458fe8d
Cr-Commit-Position: refs/heads/master@{#435923}
==========

[commit-bot: I haz the power, 2016-12-02 12:31:43]

Patchset 4 (id:??) landed as
https://crrev.com/12d3f1b37dbe91316f5c3ce2bfc006204458fe8d
Cr-Commit-Position: refs/heads/master@{#435923}