Deflake storage/domstorage/events tests when run in random order

Deflake storage/domstorage/events tests when run in random order

Unable to repro the flakiness locally but via code inspection it
appeared to be due a pattern used in 2 of the 4 tests (the flaky ones)
not navigating the iframe used as the source of the events between the
sessionStorage and localStorage passes to ensure a fresh context.
Changed those 2 tests to navigate the iframe before each pass.
Speculative fix, so fingers crossed.

The tests also used a strange mix of js-test helpers and direct
testRunner access leading to redundant "TEST PASSED" output. This was
simplified to follow usual js-test usage.

BUG=664848
R=jeffcarp@chromium.org

Committed: https://crrev.com/2c15205a5a85afaabc36afec03d92ad069e2e7a8
Cr-Commit-Position: refs/heads/master@{#435482}

[jsbell, 2016-11-29 20:27:27]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-11-29 20:27:45]

jeffcarp@ - can you please review?

[commit-bot: I haz the power, 2016-11-29 20:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 21:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 21:27:32]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2016-11-30 20:29:50]

lgtm

[jsbell, 2016-11-30 21:32:12]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:32:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:43:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 22:43:50]

Failed to apply patch for
third_party/WebKit/LayoutTests/RandomOrderExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/RandomOrderExpectations:80
  error: third_party/WebKit/LayoutTests/RandomOrderExpectations: patch does not
apply

Patch:       third_party/WebKit/LayoutTests/RandomOrderExpectations
Index: third_party/WebKit/LayoutTests/RandomOrderExpectations
diff --git a/third_party/WebKit/LayoutTests/RandomOrderExpectations
b/third_party/WebKit/LayoutTests/RandomOrderExpectations
index
4a7478e8bf97142f37ba0ef9cdefd29e0f80e37b..38c93ddf968a8154b353654a1c693d0e52cc554b
100644
--- a/third_party/WebKit/LayoutTests/RandomOrderExpectations
+++ b/third_party/WebKit/LayoutTests/RandomOrderExpectations
@@ -80,8 +80,6 @@ crbug.com/664844
media/track/track-cue-rendering-tree-is-removed-properly.html [
 crbug.com/664844 media/track/track-default-attribute.html [ Pass Failure ]
 crbug.com/664844 media/track/track-kind-user-preference.html [ Pass Failure ]
 crbug.com/664846 paint/invalidation/background-resize-height.html [ Pass
Failure ]
-crbug.com/664848 storage/domstorage/events/basic.html [ Pass Failure ]
-crbug.com/664848 storage/domstorage/events/case-sensitive.html [ Pass Failure ]
 crbug.com/664849 svg/dom/transform-parser.html [ Pass Failure ]
 crbug.com/664850
virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-webgl.html [
Pass Failure ]
 crbug.com/664850
virtual/display_list_2d_canvas/fast/canvas/canvas-drawImage-live-video.html [
Pass Failure ]

[jsbell, 2016-11-30 22:54:39]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-11-30 22:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2538773003/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-30 22:55:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:50:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480546479872400,
"parent_rev": "644e52a589b68e6f998f6e80a52130af20d0e14a", "commit_rev":
"25c53c836da2618b8c58b7926f06c242e55c9f1f"}

[commit-bot: I haz the power, 2016-11-30 23:51:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 23:53:09]

Description was changed from

==========
Deflake storage/domstorage/events tests when run in random order

Unable to repro the flakiness locally but via code inspection it
appeared to be due a pattern used in 2 of the 4 tests (the flaky ones)
not navigating the iframe used as the source of the events between the
sessionStorage and localStorage passes to ensure a fresh context.
Changed those 2 tests to navigate the iframe before each pass.
Speculative fix, so fingers crossed.

The tests also used a strange mix of js-test helpers and direct
testRunner access leading to redundant "TEST PASSED" output. This was
simplified to follow usual js-test usage.

BUG=664848
R=jeffcarp@chromium.org
==========

to

==========
Deflake storage/domstorage/events tests when run in random order

Unable to repro the flakiness locally but via code inspection it
appeared to be due a pattern used in 2 of the 4 tests (the flaky ones)
not navigating the iframe used as the source of the events between the
sessionStorage and localStorage passes to ensure a fresh context.
Changed those 2 tests to navigate the iframe before each pass.
Speculative fix, so fingers crossed.

The tests also used a strange mix of js-test helpers and direct
testRunner access leading to redundant "TEST PASSED" output. This was
simplified to follow usual js-test usage.

BUG=664848
R=jeffcarp@chromium.org

Committed: https://crrev.com/2c15205a5a85afaabc36afec03d92ad069e2e7a8
Cr-Commit-Position: refs/heads/master@{#435482}
==========

[commit-bot: I haz the power, 2016-11-30 23:53:10]

Patchset 2 (id:??) landed as
https://crrev.com/2c15205a5a85afaabc36afec03d92ad069e2e7a8
Cr-Commit-Position: refs/heads/master@{#435482}