Fix yet another silly DCHECK in the FTP code.

Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.

This CL makes the request fail if a remote path contains either
character.

BUG=669407
Committed: https://crrev.com/2d3fc642169b3997c1cb7d2169e0c9c6c98c21e8
Cr-Commit-Position: refs/heads/master@{#435045}

[mmenke, 2016-11-29 16:12:49]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 16:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-11-29 16:13:50]

Description was changed from

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in paths, but DCHECKing that commands
including paths don't contain them.  Now it just fails if a path
contains either character.

BUG=669407
==========

to

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.  Now the request just
fails if a remote path contains either character.

BUG=669407
==========

[mmenke, 2016-11-29 16:15:47]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2016-11-29 16:15:48]

I have a feeling I'll be fixing pointless things like this for quite a while. 
:(

At least we know the fuzzer is doing something.

[commit-bot: I haz the power, 2016-11-29 17:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 17:08:53]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-11-29 18:52:05]

> I have a feeling I'll be fixing pointless things like this for quite a while. 

I expect you are right.

But +1 for the fuzzer exercising previously unreached code!

[eroman, 2016-11-29 18:52:14]

lgtm

[mmenke, 2016-11-29 18:53:14]

Description was changed from

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.  Now the request just
fails if a remote path contains either character.

BUG=669407
==========

to

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.

This CL makes the request fail if a remote path contains either
character.

BUG=669407
==========

[mmenke, 2016-11-29 18:53:20]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-11-29 18:53:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 18:58:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480445600011530, "parent_rev":
"02c487eec17b1750106048c698fc88f8323005ef", "commit_rev":
"6e13a1893e1a76756b0f310b1e5c364295be88a2"}

[commit-bot: I haz the power, 2016-11-29 18:59:25]

Description was changed from

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.

This CL makes the request fail if a remote path contains either
character.

BUG=669407
==========

to

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.

This CL makes the request fail if a remote path contains either
character.

BUG=669407
==========

[commit-bot: I haz the power, 2016-11-29 18:59:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 19:01:51]

Description was changed from

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.

This CL makes the request fail if a remote path contains either
character.

BUG=669407
==========

to

==========
Fix yet another silly DCHECK in the FTP code.

The code was allowing CRs or LFs in remote paths, but DCHECKing that
commands including paths don't contain them.

This CL makes the request fail if a remote path contains either
character.

BUG=669407

Committed: https://crrev.com/2d3fc642169b3997c1cb7d2169e0c9c6c98c21e8
Cr-Commit-Position: refs/heads/master@{#435045}
==========

[commit-bot: I haz the power, 2016-11-29 19:01:52]

Patchset 1 (id:??) landed as
https://crrev.com/2d3fc642169b3997c1cb7d2169e0c9c6c98c21e8
Cr-Commit-Position: refs/heads/master@{#435045}