Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: chrome/browser/predictors/autocomplete_action_predictor_unittest.cc

Issue 2538763002: Data from the autocomplete predictor wasn't deleted immediately when deleting browsing history. (Closed)
Patch Set: revert dcheck(history_service) add dcheck(initialized_) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
diff --git a/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc b/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
index 8c9dd81f70b2e1353f1c58f3e7b1dfe43ed8e4b3..90dab789f71fc7f34b33297c5aa6e9c78ef9bf27 100644
--- a/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
+++ b/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
@@ -91,7 +91,7 @@ class AutocompleteActionPredictorTest : public testing::Test {
db_thread_(BrowserThread::DB, &loop_),
file_thread_(BrowserThread::FILE, &loop_),
profile_(new TestingProfile()),
- predictor_(new AutocompleteActionPredictor(profile_.get())) {
+ predictor_(nullptr) {
}
~AutocompleteActionPredictorTest() override {
@@ -105,8 +105,9 @@ class AutocompleteActionPredictorTest : public testing::Test {
switches::kPrerenderFromOmnibox,
switches::kPrerenderFromOmniboxSwitchValueEnabled);
- predictor_->CreateLocalCachesFromDatabase();
ASSERT_TRUE(profile_->CreateHistoryService(true, false));
+ predictor_.reset(new AutocompleteActionPredictor(profile_.get()));
+ predictor_->CreateLocalCachesFromDatabase();
profile_->BlockUntilHistoryProcessesPendingRequests();
ASSERT_TRUE(predictor_->initialized_);
@@ -115,8 +116,8 @@ class AutocompleteActionPredictorTest : public testing::Test {
}
void TearDown() override {
- profile_->DestroyHistoryService();
predictor_->Shutdown();
+ profile_->DestroyHistoryService();
}
protected:

Powered by Google App Engine
This is Rietveld 408576698