chrome/browser/predictors/autocomplete_action_predictor.h - Issue 2538763002: Data from the autocomplete predictor wasn't deleted immediately when deleting browsing history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/autocomplete_action_predictor.h

Issue 2538763002: Data from the autocomplete predictor wasn't deleted immediately when deleting browsing history. (Closed)

Patch Set: revert dcheck(history_service) add dcheck(initialized_) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/predictors/autocomplete_action_predictor.h

diff --git a/chrome/browser/predictors/autocomplete_action_predictor.h b/chrome/browser/predictors/autocomplete_action_predictor.h

index e2df03d359f18d7bdf71b47fc473657e35d2fc59..9fcb00138652c2281a3a0833742c9b3dab47d270 100644

--- a/chrome/browser/predictors/autocomplete_action_predictor.h

+++ b/chrome/browser/predictors/autocomplete_action_predictor.h

@@ -187,8 +187,8 @@ class AutocompleteActionPredictor

std::vector<AutocompleteActionPredictorTable::Row>* row_buffer);

// Attempts to call DeleteOldEntries if the in-memory database has been loaded

- // by |service|. Returns success as a boolean.

- bool TryDeleteOldEntries(history::HistoryService* service);

+ // by |service|.

+ void TryDeleteOldEntries(history::HistoryService* service);

// Called to delete any old or invalid entries from the database. Called after

// the local caches are created once the history service is available.