Data from the autocomplete predictor wasn't deleted immediately when deleting browsing history.

chrome/browser/predictors/autocomplete_action_predictor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/predictors/autocomplete_action_predictor.h"
 
 #include <math.h>
 #include <stddef.h>
 
 #include <vector>
@@ skipping 67 matching lines @@
     DCHECK(main_profile_predictor_);
     main_profile_predictor_->incognito_predictor_ = this;
     if (main_profile_predictor_->initialized_)
       CopyFromMainProfile();
   } else {
     // Request the in-memory database from the history to force it to load so
     // it's available as soon as possible.
     history::HistoryService* history_service =
         HistoryServiceFactory::GetForProfile(
             profile_, ServiceAccessType::EXPLICIT_ACCESS);
-    if (history_service)
-      history_service->InMemoryDatabase();
+    DCHECK(history_service);
+    history_service->InMemoryDatabase();
 
     table_ =
         PredictorDatabaseFactory::GetForProfile(profile_)->autocomplete_table();
 
     // Observe all main frame loads so we can wait for the first to complete
     // before accessing DB and IO threads to build the local cache.
     notification_registrar_.Add(this,
                                 content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
                                 content::NotificationService::AllSources());
   }
@@ skipping 228 matching lines @@
   std::vector<AutocompleteActionPredictorTable::Row>* rows =
       new std::vector<AutocompleteActionPredictorTable::Row>();
   content::BrowserThread::PostTaskAndReply(
       content::BrowserThread::DB, FROM_HERE,
       base::Bind(&AutocompleteActionPredictorTable::GetAllRows, table_, rows),
       base::Bind(&AutocompleteActionPredictor::CreateCaches, AsWeakPtr(),
                  base::Owned(rows)));
 }
 
 void AutocompleteActionPredictor::DeleteAllRows() {
   if (!initialized_)

[pasko, 2016/12/15 12:57:35]

nit: DCHECK here as well?

[dullweber, 2016/12/15 14:52:18]

Done.

     return;
 
   db_cache_.clear();
   db_id_cache_.clear();
 
   if (table_.get()) {
     content::BrowserThread::PostTask(
         content::BrowserThread::DB, FROM_HERE,
         base::Bind(&AutocompleteActionPredictorTable::DeleteAllRows, table_));
   }
@@ skipping 86 matching lines @@
     const DBCacheKey key = { it->user_text, it->url };
     const DBCacheValue value = { it->number_of_hits, it->number_of_misses };
     db_cache_[key] = value;
     db_id_cache_[key] = it->id;
   }
 
   // If the history service is ready, delete any old or invalid entries.
   history::HistoryService* history_service =
       HistoryServiceFactory::GetForProfile(profile_,
                                            ServiceAccessType::EXPLICIT_ACCESS);
-  if (!TryDeleteOldEntries(history_service)) {
-    // Wait for the notification that the history service is ready and the URL
-    // DB is loaded.
-    if (history_service)
-      history_service_observer_.Add(history_service);
-  }
+  TryDeleteOldEntries(history_service);
+  DCHECK(history_service);
+  history_service_observer_.Add(history_service);
 }
 
-bool AutocompleteActionPredictor::TryDeleteOldEntries(
+void AutocompleteActionPredictor::TryDeleteOldEntries(
     history::HistoryService* service) {
   CHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!profile_->IsOffTheRecord());
   DCHECK(!initialized_);
 
   if (!service)
-    return false;
+    return;
 
   history::URLDatabase* url_db = service->InMemoryDatabase();
   if (!url_db)
-    return false;
+    return;
 
   DeleteOldEntries(url_db);
-  return true;
 }
 
 void AutocompleteActionPredictor::DeleteOldEntries(
     history::URLDatabase* url_db) {
   CHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!profile_->IsOffTheRecord());
   DCHECK(!initialized_);
   DCHECK(table_.get());
 
   std::vector<AutocompleteActionPredictorTable::Row::Id> ids_to_delete;
@@ skipping 84 matching lines @@
 void AutocompleteActionPredictor::Shutdown() {
   history_service_observer_.RemoveAll();
 }
 
 void AutocompleteActionPredictor::OnURLsDeleted(
     history::HistoryService* history_service,
     bool all_history,
     bool expired,
     const history::URLRows& deleted_rows,
     const std::set<GURL>& favicon_urls) {
-  if (!initialized_)
-    return;
+  DCHECK(initialized_);
 
   if (all_history)
     DeleteAllRows();
   else
     DeleteRowsWithURLs(deleted_rows);
 }
 
 void AutocompleteActionPredictor::OnHistoryServiceLoaded(
     history::HistoryService* history_service) {
-  TryDeleteOldEntries(history_service);
-  history_service_observer_.Remove(history_service);
+  if (!initialized_)
+    TryDeleteOldEntries(history_service);
 }
 
 AutocompleteActionPredictor::TransitionalMatch::TransitionalMatch() {
 }
 
 AutocompleteActionPredictor::TransitionalMatch::TransitionalMatch(
     const TransitionalMatch& other) = default;
 
 AutocompleteActionPredictor::TransitionalMatch::~TransitionalMatch() {
 }
 
 }  // namespace predictors