Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2538703002: lcms: avoid fixed number LUT optimization on inf values (Closed)

Created:
4 years ago by kcwu
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

lcms: avoid fixed number LUT optimization on inf values BUG=chromium:666705 Committed: https://pdfium.googlesource.com/pdfium/+/31559c91c4983b42361415d30b0b2a518c7ef383

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -9 lines) Patch
A third_party/lcms2-2.6/0014-avoid-fixed-inf.patch View 1 1 chunk +95 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/README.pdfium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/lcms2-2.6/src/cmsopt.c View 7 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
kcwu
No response from upstream https://github.com/mm2/Little-CMS/pull/108 yet. Let's fix chrome locally first.
4 years ago (2016-12-05 04:32:05 UTC) #2
dsinclair
lgtm
4 years ago (2016-12-05 14:17:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538703002/1
4 years ago (2016-12-05 14:18:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/builds/3088) linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED, ...
4 years ago (2016-12-05 14:19:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538703002/20001
4 years ago (2016-12-08 01:14:19 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 01:35:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/31559c91c4983b42361415d30b0b2a518c7e...

Powered by Google App Engine
This is Rietveld 408576698