Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: src/lookup.cc

Issue 2538693002: Revert of [ic] Use validity cells to protect keyed element stores against object's prototype chain… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic-inl.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 593e6928f9ae79f9e67c96953e10141f38e9a2c9..186823df8470b2faf0453cc5002c79e9a801f57c 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -526,8 +526,11 @@
Handle<SeededNumberDictionary> dictionary =
JSObject::NormalizeElements(receiver);
- dictionary = SeededNumberDictionary::Set(dictionary, index_, pair, details,
- receiver);
+ // We unconditionally pass used_as_prototype=false here because the call
+ // to RequireSlowElements takes care of the required IC clearing and
+ // we don't want to walk the heap twice.
+ dictionary =
+ SeededNumberDictionary::Set(dictionary, index_, pair, details, false);
receiver->RequireSlowElements(*dictionary);
if (receiver->HasSlowArgumentsElements()) {
« no previous file with comments | « src/ic/ic-inl.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698