Revert of [ic] Use validity cells to protect keyed element stores against object's prototype chain…

Revert of [ic] Use validity cells to protect keyed element stores against object's prototype chain modificati… (patchset #2 id:40001 of https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11691

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's prototype chain modifications.
>
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
>
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
>
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561
Committed: https://crrev.com/9c0e2a6723e3f4ea1c181d235a08b1115663d39a
Cr-Commit-Position: refs/heads/master@{#41337}

[Michael Achenbach, 2016-11-29 08:49:00]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-11-29 08:49:01]

Created Revert of [ic] Use validity cells to protect keyed element stores
against object's prototype chain modificati…

[commit-bot: I haz the power, 2016-11-29 08:49:29]

Description was changed from

==========
Revert of [ic] Use validity cells to protect keyed element stores against
object's prototype chain modificati… (patchset #2 id:40001 of
https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's
prototype chain modifications.
> 
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
> 
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
> 
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561
==========

to

==========
Revert of [ic] Use validity cells to protect keyed element stores against
object's prototype chain modificati… (patchset #2 id:40001 of
https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's
prototype chain modifications.
> 
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
> 
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
> 
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561
==========

[commit-bot: I haz the power, 2016-11-29 08:49:58]

Description was changed from

==========
Revert of [ic] Use validity cells to protect keyed element stores against
object's prototype chain modificati… (patchset #2 id:40001 of
https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's
prototype chain modifications.
> 
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
> 
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
> 
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561
==========

to

==========
Revert of [ic] Use validity cells to protect keyed element stores against
object's prototype chain modificati… (patchset #2 id:40001 of
https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's
prototype chain modifications.
>
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
>
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
>
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561

Committed: https://crrev.com/9c0e2a6723e3f4ea1c181d235a08b1115663d39a
Cr-Commit-Position: refs/heads/master@{#41337}
==========

[Michael Achenbach, 2016-11-29 08:52:34]

Uh, why was this issue closed on creation??

Meh, title length :(((

[Michael Achenbach, 2016-11-29 08:52:46]

Description was changed from

==========
Revert of [ic] Use validity cells to protect keyed element stores against
object's prototype chain modificati… (patchset #2 id:40001 of
https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's
prototype chain modifications.
>
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
>
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
>
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561

Committed: https://crrev.com/9c0e2a6723e3f4ea1c181d235a08b1115663d39a
Cr-Commit-Position: refs/heads/master@{#41337}
==========

to

==========
Revert of [ic] Use validity cells to protect keyed element stores against
object's prototype chain modificati… (patchset #2 id:40001 of
https://codereview.chromium.org/2534613002/ )

Reason for revert:
Layout test crashes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Original issue's description:
> [ic] Use validity cells to protect keyed element stores against object's
prototype chain modifications.
>
> ... instead of clearing of all the KeyedStoreICs which didn't always work.
>
> BUG=chromium:662907, v8:5561
> TBR=verwaest@chromium.org, bmeurer@chromium.org
>
> Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf
> Cr-Commit-Position: refs/heads/master@{#41332}

TBR=jkummerow@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662907, v8:5561

Committed: https://crrev.com/9c0e2a6723e3f4ea1c181d235a08b1115663d39a
Cr-Commit-Position: refs/heads/master@{#41337}
==========

[Michael Achenbach, 2016-11-29 08:52:50]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-11-29 08:52:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 08:53:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 08:53:08]

Failed to apply patch for include/v8.h:
While running git apply --index -p1;
  error: patch failed: include/v8.h:8326
  error: include/v8.h: patch does not apply

Patch:       include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
5d8b1b3c01fb259157858593b8eb768a37cb80a2..ccac0244da949d0f762b0411c4c24e5f60f5c8a8
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -8326,8 +8326,8 @@
   static const int kNodeIsIndependentShift = 3;
   static const int kNodeIsActiveShift = 4;
 
-  static const int kJSObjectType = 0xbd;
-  static const int kJSApiObjectType = 0xbc;
+  static const int kJSObjectType = 0xbc;
+  static const int kJSApiObjectType = 0xbb;
   static const int kFirstNonstringType = 0x80;
   static const int kOddballType = 0x83;
   static const int kForeignType = 0x87;

[Michael Achenbach, 2016-11-29 08:55:36]

Double Uh! CL landed:
https://chromium.googlesource.com/v8/v8/+/9c0e2a6723e3f4ea1c181d235a08b111566...

Closing manually.