Chromium Code Reviews Chromium Code Reviews
Issue 2538653002:
bluetooth: Add sidebar and page manager for chrome://bluetooth-internals. (Closed)
| Index: chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| diff --git a/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html b/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| index 6181899737095845cece92ab4cde39afb199ba7a..0cb1f285791d74db9d2894c9925944ca5c80bfa2 100644 |
| --- a/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| +++ b/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html |
| @@ -6,26 +6,43 @@ |
| <meta charset="utf-8"> |
| <meta name="viewport" content="width=device-width, initial-scale=1"> |
| <title>Bluetooth Internals</title> |
| - <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> |
| + <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> |
| <link rel="stylesheet" href="bluetooth_internals.css"> |
| + |
| <link rel="import" href="chrome://resources/html/cr/ui.html"> |
| <link rel="import" href="chrome://resources/html/cr/event_target.html"> |
| <link rel="import" href="chrome://resources/html/cr/ui/array_data_model.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/focus_outline_manager.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/overlay.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/page_manager/page_manager.html"> |
| + <link rel="import" href="chrome://resources/html/cr/ui/page_manager/page.html"> |
| <link rel="import" href="chrome://resources/html/util.html"> |
| <script src="interfaces.js"></script> |
| <script src="adapter_broker.js"></script> |
| <script src="device_collection.js"></script> |
| <script src="device_table.js"></script> |
| + <script src="devices_view.js"></script> |
| + <script src="sidebar.js"></script> |
| <script src="bluetooth_internals.js"></script> |
| </head> |
| <body> |
| - <header> |
| - <div class="title"> |
| - Bluetooth Internals |
| + <div id="menu-btn"></div> |
|
ortuno
2016/12/01 06:27:03
menu-btn and overlay seem really out place semanti
mbrunson
2016/12/02 02:31:45
- I've added semantic tags.
- Changing the order
|
| + <div id="sidebar"> |
| + <h1>Bluetooth Internals</h1> |
| + <ul role="tablist"> |
| + <li class="selected" data-page-name="devices">Devices</li> |
|
ortuno
2016/12/01 06:27:03
Would it make sense to just set the title based on
mbrunson
2016/12/02 02:31:45
The menu button is now a part of the page header.
|
| + </ul> |
| + </div> |
| + <div id="overlay"></div> |
| + <div id="page-container"> |
| + <div id="devices"> |
| + <header> |
| + <h1>Devices</h1> |
| + </header> |
| </div> |
| - </header> |
| + </div> |
|
ortuno
2016/12/01 06:27:03
https://developer.mozilla.org/en-US/docs/Web/Guide
mbrunson
2016/12/02 02:31:45
Done.
|
| </body> |
| <template id="table-template"> |
| @@ -39,7 +56,7 @@ |
| <th data-field="is_gatt_connected">GATT Connection State</th> |
| </tr> |
| </thead> |
| - <tbody class="table-body"> |
| + <tbody> |
| </tbody> |
| </table> |
| </template> |
