Handle "as" in kernel with ir.AsExpression case.

Handle "as" in kernel with ir.AsExpression case.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/ecb9b3618a5fa4461eb02bffaa96cafbb87f5abd

[Emily Fortuna, 2016-11-29 02:32:16]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2016-11-29 02:35:38]

efortuna@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-11-29 03:39:47]

LGTM with test fix (or modifying a language test to cover this case)

https://codereview.chromium.org/2538643002/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_extra/as_operator_test.dart (right):

https://codereview.chromium.org/2538643002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_extra/as_operator_test.dart:21: Expect.equals(5, (c as
C).foo());
It is possible that these are optimized away completely.
You could make one of the 'as' expressions (b or c) have an input that is not
directly the HCreate with a known type.

if (confuse(false)) c = new A();

@NoInline() @AssumeDynamic()
confuse(x) => x;

If there is already a language test that does this, nevermind.

[Emily Fortuna, 2016-11-29 20:46:49]

Description was changed from

==========
Handle "as" in kernel with ir.AsExpression case.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Handle "as" in kernel with ir.AsExpression case.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ecb9b3618a5fa4461eb02bffaa96cafbb87f5abd
==========

[Emily Fortuna, 2016-11-29 20:46:49]

Committed patchset #2 (id:40001) manually as
ecb9b3618a5fa4461eb02bffaa96cafbb87f5abd (presubmit successful).

[Emily Fortuna, 2016-11-29 20:47:52]

https://codereview.chromium.org/2538643002/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_extra/as_operator_test.dart (right):

https://codereview.chromium.org/2538643002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_extra/as_operator_test.dart:21: Expect.equals(5, (c as
C).foo());
On 2016/11/29 03:39:47, sra1 wrote:
> It is possible that these are optimized away completely.
> You could make one of the 'as' expressions (b or c) have an input that is not
> directly the HCreate with a known type.
> 
> if (confuse(false)) c = new A();
> 
> @NoInline() @AssumeDynamic()
> confuse(x) => x;
> 
> If there is already a language test that does this, nevermind.

found the language test in type_error_test. removing this test.