Adds a couple more properties to the property converter

Adds a couple more properties to the property converter

This also adds PropertyConverter::GetPropertyValueFromTransformValue()
which I need in ash for values used in creation of the window but
don't make their way into real properties.

BUG=664625
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/153f6770e0347b20dc07c3d10bda3e82db01b7fc
Cr-Commit-Position: refs/heads/master@{#435026}

[sky, 2016-11-29 00:32:38]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 00:34:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:44:49]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[msw, 2016-11-29 01:15:45]

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.cc:55: for (auto& pair : properties)
It seems easy for a client to inline this; why add the helper?
If you keep this; add a unit test fixture.

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.h (right):

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:33: // All primitive values are represented as
this
nit: trailing period; optionally "are stored using this type."

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:68: // value of false indicates the value isn't
known.
"or the property type isn't primitive."

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:69: bool GetPropertyValueFromTransformValue(
s/Transform/Transport/?

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/desktop_wi...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:560: // TODO: replace above keys
with kResizeBehaviorKey. http://crbug.com/669290.
Neat, I was gonna ask about this; I'll take this bug.

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/mus_client.cc
File ui/views/mus/mus_client.cc (left):

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/mus_client...
ui/views/mus/mus_client.cc:82: // static
Why can't/shouldn't this be static anymore?

[sky, 2016-11-29 04:19:37]

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.cc:55: for (auto& pair : properties)
On 2016/11/29 01:15:45, msw wrote:
> It seems easy for a client to inline this; why add the helper?
> If you keep this; add a unit test fixture.

I need to call it a couple of times, but it's not critical. Nuked.

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
File ui/aura/mus/property_converter.h (right):

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:33: // All primitive values are represented as
this
On 2016/11/29 01:15:45, msw wrote:
> nit: trailing period; optionally "are stored using this type."

Done.

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:68: // value of false indicates the value isn't
known.
On 2016/11/29 01:15:45, msw wrote:
> "or the property type isn't primitive."

Done.

https://codereview.chromium.org/2538633002/diff/20001/ui/aura/mus/property_co...
ui/aura/mus/property_converter.h:69: bool GetPropertyValueFromTransformValue(
On 2016/11/29 01:15:45, msw wrote:
> s/Transform/Transport/?

Wow! And I just started wearing glasses. Apparently I need to increase the
prescription!

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/desktop_wi...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:560: // TODO: replace above keys
with kResizeBehaviorKey. http://crbug.com/669290.
On 2016/11/29 01:15:45, msw wrote:
> Neat, I was gonna ask about this; I'll take this bug.

Thanks!

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/mus_client.cc
File ui/views/mus/mus_client.cc (left):

https://codereview.chromium.org/2538633002/diff/20001/ui/views/mus/mus_client...
ui/views/mus/mus_client.cc:82: // static
On 2016/11/29 01:15:45, msw wrote:
> Why can't/shouldn't this be static anymore?

Good point. Done.

[sky, 2016-11-29 04:24:56]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 04:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 05:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 05:42:45]

Dry run: This issue passed the CQ dry run.

[msw, 2016-11-29 17:43:48]

lgtm

[sky, 2016-11-29 17:44:25]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-11-29 17:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 17:49:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480441465950530,
"parent_rev": "f0527b8589c4b3c17ef99a0d3ec064ec3bc68c99", "commit_rev":
"08219c4a7d207ed1a4366b93f5b9bcc47eb363ac"}

[commit-bot: I haz the power, 2016-11-29 17:50:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-29 17:52:11]

Description was changed from

==========
Adds a couple more properties to the property converter

This also adds PropertyConverter::GetPropertyValueFromTransformValue()
which I need in ash for values used in creation of the window but
don't make their way into real properties.

BUG=664625
TEST=none
R=msw@chromium.org
==========

to

==========
Adds a couple more properties to the property converter

This also adds PropertyConverter::GetPropertyValueFromTransformValue()
which I need in ash for values used in creation of the window but
don't make their way into real properties.

BUG=664625
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/153f6770e0347b20dc07c3d10bda3e82db01b7fc
Cr-Commit-Position: refs/heads/master@{#435026}
==========

[commit-bot: I haz the power, 2016-11-29 17:52:12]

Patchset 4 (id:??) landed as
https://crrev.com/153f6770e0347b20dc07c3d10bda3e82db01b7fc
Cr-Commit-Position: refs/heads/master@{#435026}