Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 253863004: Mojo: More Channel tests. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : delete extra blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -3 lines) Patch
M mojo/system/channel.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/system/channel_unittest.cc View 1 2 chunks +140 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 7 months ago (2014-04-28 17:43:35 UTC) #1
yzshen1
lgtm
6 years, 7 months ago (2014-04-28 17:50:59 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-04-28 18:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/253863004/20001
6 years, 7 months ago (2014-04-28 18:02:53 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 22:32:09 UTC) #5
Message was sent while issue was closed.
Change committed as 266676

Powered by Google App Engine
This is Rietveld 408576698