Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2538613002: CSS Variables: Fix double include of testharness.js (Closed)

Created:
4 years ago by Eric Willigers
Modified:
4 years ago
Reviewers:
sashab
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Variables: Fix double include of testharness.js Fix the two tests identified by git grep "/testharness.js" | grep "<script" | cut -d':' -f1 | uniq -d Problem spotted by geoffers@gmail.com BUG=634567 Committed: https://crrev.com/804776f216c2d2747773aa28a7bdb49c39d173c8 Cr-Commit-Position: refs/heads/master@{#435221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization.html View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/variables/custom-properties-serialization-quirks-mode.html View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Eric Willigers
4 years ago (2016-11-28 23:42:28 UTC) #2
sashab
lgtm
4 years ago (2016-11-29 23:27:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538613002/1
4 years ago (2016-11-29 23:44:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 01:46:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538613002/1
4 years ago (2016-11-30 02:42:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 04:43:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538613002/1
4 years ago (2016-11-30 11:35:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 11:40:30 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-30 11:45:12 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/804776f216c2d2747773aa28a7bdb49c39d173c8
Cr-Commit-Position: refs/heads/master@{#435221}

Powered by Google App Engine
This is Rietveld 408576698