Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 2538573002: [Media Remoting] Update error messaging. (Closed)

Created:
4 years ago by apacible
Modified:
4 years ago
Reviewers:
miu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Remoting] Update error messaging. Per discussion with UX. Committed: https://crrev.com/41cc9c159cddbd115e723bcc7b07c1f1ae745449 Cr-Commit-Position: refs/heads/master@{#435017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
apacible
PTAL, thanks!
4 years ago (2016-11-28 22:55:54 UTC) #5
miu
lgtm
4 years ago (2016-11-28 23:25:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538573002/1
4 years ago (2016-11-29 17:14:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 17:20:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 17:22:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41cc9c159cddbd115e723bcc7b07c1f1ae745449
Cr-Commit-Position: refs/heads/master@{#435017}

Powered by Google App Engine
This is Rietveld 408576698