Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2538513002: [ash-md] Fixed TriView to relayout child Views when their preferred size changed. (Closed)

Created:
4 years ago by bruthig
Modified:
4 years ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixed TriView to relayout child Views when their preferred size changed. Previously TriView child views would be allocated their preferred size during the TriView layout. However, if a child view's preferred size later changed it did not trigger a TriView layout and the child view would not be allocated space based on its new preferred size. This change fixes it so that a TriView's child will be reallocated space if its preferred size changes. This will not cause the TriView container views to be resized when a child views preferred size changes. BUG=667955 TEST=ash_unittests --gtest_filter=TriViewTest.ChildViewsPreferredSizeChanged Committed: https://crrev.com/0f07a3024a009d9a367d07a2740a3ac96558ab79 Cr-Commit-Position: refs/heads/master@{#434818}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M ash/common/system/tray/tri_view.cc View 2 chunks +15 lines, -3 lines 1 comment Download
M ash/common/system/tray/tri_view_unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M ui/views/layout/box_layout_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/test_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/test_views.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bruthig
tdanderson@, can you PTAL?
4 years ago (2016-11-28 20:11:16 UTC) #3
tdanderson
LGTM https://codereview.chromium.org/2538513002/diff/1/ash/common/system/tray/tri_view.cc File ash/common/system/tray/tri_view.cc (right): https://codereview.chromium.org/2538513002/diff/1/ash/common/system/tray/tri_view.cc#newcode31 ash/common/system/tray/tri_view.cc:31: class RelayoutView : public views::View { Hm, I'm ...
4 years ago (2016-11-28 21:47:37 UTC) #5
bruthig
sky@, can you take a quick look at ui/views/*?
4 years ago (2016-11-28 22:01:17 UTC) #8
sky
LGTM
4 years ago (2016-11-28 22:46:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538513002/1
4 years ago (2016-11-29 01:13:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:44:33 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 01:48:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f07a3024a009d9a367d07a2740a3ac96558ab79
Cr-Commit-Position: refs/heads/master@{#434818}

Powered by Google App Engine
This is Rietveld 408576698