Issue 2538503002: Remove support for summary "fallback mode" from analyzer.

Issue 2538503002: Remove support for summary "fallback mode" from analyzer. (Closed)

Created:
4 years ago by Paul Berry

Modified:
4 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove support for summary "fallback mode" from analyzer. This feature was added as a stopgap in case summaries proved unreliable. It is no longer needed. Fixes #27916. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e926a84ec254bedda0b5bb28a8e360e2868fa843

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -123 lines)			Patch
M	pkg/analyzer/lib/src/summary/format.dart	View	20 chunks	+6 lines, -53 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.fbs	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/idl.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View	4 chunks	+3 lines, -46 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/in_summary_source_test.dart	View	3 chunks	+2 lines, -22 lines	0 comments	Download

Total messages: 6 (2 generated)

scheglov

LGTM I think there was also some fallback related code in analyzer_cli, do we want ...

4 years ago (2016-11-28 19:38:23 UTC) #3

Paul Berry

On 2016/11/28 19:38:23, scheglov wrote: > LGTM > > I think there was also some ...

4 years ago (2016-11-28 20:11:47 UTC) #4

Paul Berry

4 years ago (2016-11-28 20:12:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e926a84ec254bedda0b5bb28a8e360e2868fa843 (presubmit successful).