Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25385002: Remove the BufferedInputRouter (Closed)

Created:
7 years, 2 months ago by jdduke (slow)
Modified:
7 years, 2 months ago
Reviewers:
nduca, Chris Evans, piman
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the BufferedInputRouter Remove the BufferedInputRouter, InputQueue and EventPacket. After further review and discussion, it's been decided that vsync-aligned input handling would best be added to the input pipeline via incremental updates, beginning with event types that currently rely on coaelescing and browser-side buffering. BUG=245499 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226224

Patch Set 1 #

Total comments: 4

Patch Set 2 : Space removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1931 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/renderer_host/input/browser_input_event.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/browser/renderer_host/input/browser_input_event.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D content/browser/renderer_host/input/buffered_input_router.h View 1 chunk +0 lines, -144 lines 0 comments Download
D content/browser/renderer_host/input/buffered_input_router.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D content/browser/renderer_host/input/buffered_input_router_unittest.cc View 1 chunk +0 lines, -320 lines 0 comments Download
D content/browser/renderer_host/input/input_queue.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/browser/renderer_host/input/input_queue.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D content/browser/renderer_host/input/input_queue_client.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/browser/renderer_host/input/input_queue_unittest.cc View 1 chunk +0 lines, -363 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 4 chunks +4 lines, -14 lines 0 comments Download
D content/common/input/event_packet.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/common/input/event_packet.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D content/common/input/input_event_disposition.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/common/input/input_event_disposition.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M content/common/input/input_param_traits.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/common/input/input_param_traits.cc View 1 2 chunks +0 lines, -38 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 6 chunks +32 lines, -77 lines 0 comments Download
M content/common/input_messages.h View 4 chunks +0 lines, -13 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jdduke (slow)
All code being removed was used behind a (disabled) flag. PTAL for owners. The only ...
7 years, 2 months ago (2013-09-30 23:23:48 UTC) #1
nduca
I suggest updating the cl description with context for why we are deleting it. Given ...
7 years, 2 months ago (2013-09-30 23:28:23 UTC) #2
piman
LGTM+nits https://codereview.chromium.org/25385002/diff/1/content/browser/renderer_host/render_widget_host_impl.h File content/browser/renderer_host/render_widget_host_impl.h (right): https://codereview.chromium.org/25385002/diff/1/content/browser/renderer_host/render_widget_host_impl.h#newcode767 content/browser/renderer_host/render_widget_host_impl.h:767: nit: remove one of these 2 blank lines ...
7 years, 2 months ago (2013-09-30 23:46:20 UTC) #3
jdduke (slow)
cevans@: Security review for content/common/input_messages.h ? Thanks. Hopefully it doesn't give you too much trouble ...
7 years, 2 months ago (2013-09-30 23:56:12 UTC) #4
Chris Evans
On 2013/09/30 23:56:12, jdduke wrote: > cevans@: Security review for content/common/input_messages.h ? Thanks. > Hopefully ...
7 years, 2 months ago (2013-10-01 01:06:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/25385002/10001
7 years, 2 months ago (2013-10-01 02:45:04 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 2 months ago (2013-10-01 02:45:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/25385002/10001
7 years, 2 months ago (2013-10-01 02:48:47 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-01 07:49:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/25385002/10001
7 years, 2 months ago (2013-10-01 13:12:35 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 13:43:27 UTC) #11
Message was sent while issue was closed. 
Change committed as 226224

Powered by Google App Engine
This is Rietveld 408576698