Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 2538493005: Added initial_keyword flag to CSSProperties.in (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added initial_keyword flag to CSSProperties.in Added initial_keyword flag to CSSProperties.in, which specifies the initial value for keyword-only properties generated in ComputedStyle. BUG=628043 Committed: https://crrev.com/f3cfe7729123c2dd2dcba3048b57696f325cf5a1 Cr-Commit-Position: refs/heads/master@{#435549}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M third_party/WebKit/Source/build/scripts/css_properties.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 8 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sashab
:D wdyt
3 years, 8 months ago (2016-12-01 00:56:11 UTC) #2
napper
lgtm https://codereview.chromium.org/2538493005/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2538493005/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode67 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:67: 'for property %s' % property['name']) 'for property ' ...
3 years, 8 months ago (2016-12-01 02:10:02 UTC) #3
Timothy Loh
https://codereview.chromium.org/2538493005/diff/1/third_party/WebKit/Source/build/scripts/css_properties.py File third_party/WebKit/Source/build/scripts/css_properties.py (right): https://codereview.chromium.org/2538493005/diff/1/third_party/WebKit/Source/build/scripts/css_properties.py#newcode37 third_party/WebKit/Source/build/scripts/css_properties.py:37: 'initial_keyword': [], If this isn't meant to be multi-valued, ...
3 years, 8 months ago (2016-12-01 02:14:28 UTC) #4
sashab
ty napper@! alancutter@ ptal :D https://codereview.chromium.org/2538493005/diff/1/third_party/WebKit/Source/build/scripts/css_properties.py File third_party/WebKit/Source/build/scripts/css_properties.py (right): https://codereview.chromium.org/2538493005/diff/1/third_party/WebKit/Source/build/scripts/css_properties.py#newcode37 third_party/WebKit/Source/build/scripts/css_properties.py:37: 'initial_keyword': [], On 2016/12/01 ...
3 years, 8 months ago (2016-12-01 02:35:21 UTC) #6
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2016-12-01 02:40:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538493005/20001
3 years, 8 months ago (2016-12-01 02:42:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 8 months ago (2016-12-01 04:14:37 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2016-12-01 04:16:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3cfe7729123c2dd2dcba3048b57696f325cf5a1
Cr-Commit-Position: refs/heads/master@{#435549}

Powered by Google App Engine
This is Rietveld 408576698