Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2538493004:
Remove isolate_driver.py. (Closed)
DescriptionRemove isolate_driver.py.
It is a left over from before the GYP->GN conversion.
R=dpranke@chromium.org
BUG=
Committed: https://crrev.com/fd442e9c154b054c25980691920a7196d78d0cd6
Cr-Commit-Position: refs/heads/master@{#435242}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=vadimsh@chromium.org BUG= ========== to ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=vadimsh@chromium.org TBR=dpranke@chromium.org BUG= ==========
maruel@chromium.org changed reviewers: + dpranke@chromium.org
+Dirk since we're not owners anymore.
lgtm.
The CQ bit was checked by maruel@chromium.org
The CQ bit was unchecked by maruel@chromium.org
Description was changed from ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=vadimsh@chromium.org TBR=dpranke@chromium.org BUG= ========== to ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=dpranke@chromium.org BUG= ==========
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480513312042870, "parent_rev":
"710c5a480442e0b98c43a8cbf0f6ff83ec8c33b3", "commit_rev":
"d418dc616ee71d16c741195c4357a1a0ea6c157d"}
Message was sent while issue was closed.
Description was changed from ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=dpranke@chromium.org BUG= ========== to ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=dpranke@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=dpranke@chromium.org BUG= ========== to ========== Remove isolate_driver.py. It is a left over from before the GYP->GN conversion. R=dpranke@chromium.org BUG= Committed: https://crrev.com/fd442e9c154b054c25980691920a7196d78d0cd6 Cr-Commit-Position: refs/heads/master@{#435242} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fd442e9c154b054c25980691920a7196d78d0cd6 Cr-Commit-Position: refs/heads/master@{#435242} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
