chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: address comments from creis@ and holte@ + rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc ('K') | « chrome/common/safe_browsing/csd.proto ('k') | chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html

diff --git a/chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html b/chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html

new file mode 100644

index 0000000000000000000000000000000000000000..553f241a795fea1878e881c17a143d1403882ee7

--- /dev/null

+++ b/chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html

@@ -0,0 +1,19 @@

+<html>

+ <head>

+ <script>

Charlie Reis 2016/12/14 07:43:58 I meant that the <script> tag has the wrong indent

Jialiu Lin 2016/12/14 19:06:29 Yes, you're right, there is a tab in front of <scr

+ // Click on a link by id to start a test case.

+ function clickLink(linkId) {

+ var node = document.getElementById(linkId);

+ if (node != null) {

+ // Click and open link in the same tab.

+ node.click();

+ }

+ </script>

+ </head>

+ <body>

+ <a id="download_on_landing_page" href="../signed.exe">

+ Direct download from landing page

+ </a><br>

+ </body>

+</html>