chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/landing_referrer.html

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: filter out browser side navigation browser tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 // Click on a link by id to star a test case.
	Nathan Parker 2016/12/05 22:21:24 "to start" "to start" Jialiu Lin 2016/12/06 23:10:07 Done. Show quoted text On 2016/12/05 22:21:24, Nathan Parker wrote: > "to start" Done.
	5 function clickLink(linkId) {

	6 var node = document.getElementById(linkId);

	7 if (node != null) {
	Nathan Parker 2016/12/05 22:21:24 nit: Is there any case when this could be null? If nit: Is there any case when this could be null? If not, you could skip this check. Jialiu Lin 2016/12/06 23:10:07 Sure. sounds good. Show quoted text On 2016/12/05 22:21:24, Nathan Parker wrote: > nit: Is there any case when this could be null? If not, you could skip this > check. Sure. sounds good.
	8 // Click and open link in the same tab.

	9 node.click();

	10 }

	11 }

	12 </script>

	13 </head>

	14 <body>

	15 <a id="link_to_landing" href="landing.html">

	16 Link to landing

	17 </a><br>

	18 </body>

	19 </html>

OLD	NEW