Add management related code to SafeBrowsingNavigationObserverManager

chrome/common/safe_browsing/csd.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This proto file includes:
 // (1) Client side phishing and malware detection request and response
 //   protocol buffers.  Those protocol messages should be kept in sync
 //   with the server implementation.
 //
 // (2) Safe Browsing reporting protocol buffers.
@@ skipping 364 matching lines @@
   optional bool skipped_url_whitelist = 28;
 
   // True if this ClientDownloadRequest contains a whitelisted certificate.
   optional bool skipped_certificate_whitelist = 31;
 
   // PPAPI_SAVE_REQUEST type messages may have more than one suggested filetype.
   // Each element in this collection indicates an alternate extension including
   // the leading extension separator.
   repeated string alternate_extensions = 35;
 
-  message URLChainEntry {
+  message ReferrerChainEntry {

[Nathan Parker, 2016/12/05 22:21:24]

This doesn't look like a backward-compatible change.  Is that the intention?

Another idea: we could add "ReferrerChainEntry referrer_chain_entry=37" and keep
"URLChainEntry urlchain=36" and continue to populate the latter until the
backend code no longer looks at it.

Or just ensure it's backward compatible, and plan to do a big (mechanical)
renaming of things in Google3 so it matches.

[Jialiu Lin, 2016/12/06 23:10:06]

So far, backend is not using field 36. So I guess it is still safe to make these
changes. 
I'll make sure google3 proto updated before I land this CL. 

[Nathan Parker, 2016/12/06 23:31:32]

Ah great then if it's not being used there's no issue.

     enum URLType {
       DOWNLOAD_URL = 1;
-      DOWNLOAD_REFERRER = 2;
-      LANDING_PAGE = 3;
-      LANDING_REFERRER = 4;
-      CLIENT_REDIRECT = 5;
-      SERVER_REDIRECT = 6;
+      LANDING_PAGE = 2;
+      LANDING_REFERRER = 3;
+      CLIENT_REDIRECT = 4;
+      SERVER_REDIRECT = 5;
     }
 
     // [required] The url of this Entry.
     optional string url = 1;
 
     // Type of URLs, such as download url, download referrer, etc.
     optional URLType type = 2;
 
-    // IP address corresponding to url.
-    optional string ip_address = 3;
+    // IP addresses corresponding to this host.
+    repeated string ip_address = 3;
 
     // Referrer url of this entry.
-    optional string referrer = 4;
+    optional string referrer_url = 4;
 
     // Main frame URL of referrer.
-    optional string main_frame_referrer = 5;
+    optional string referrer_main_frame_url = 5;
 
     // If this URL loads in a different tab/frame from previous one.
     optional bool is_retargeting = 6;
 
-    // If there is a user gesture attached to this transition.
-    optional bool is_user_initiated = 7;
-
-    optional double timestamp_in_millisec = 8;
+    optional double navigation_time_msec = 7;
   }  // End of URLChainEntry
 
   // URLs transitions from landing referrer to download in reverse chronological
   // order, i.e. download url comes first in this list, and landing referrer
   // comes last.
-  repeated URLChainEntry url_chain = 36;
+  repeated ReferrerChainEntry referrer_chain_entry = 36;
 }
 
 message ClientDownloadResponse {
   enum Verdict {
     // Download is considered safe.
     SAFE = 0;
     // Download is considered dangerous.  Chrome should show a warning to the
     // user.
     DANGEROUS = 1;
     // Download is uncommon.  Chrome should display a less severe warning.
@@ skipping 399 matching lines @@
   optional bool did_proceed = 8;
 
   // Whether user visited this origin before.
   optional bool repeat_visit = 9;
 
   // The same token in ClientDownloadResponse. This field is only set if its
   // report type is DANGEROUS_DOWNLOAD_RECOVERY, DANGEROUS_DOWNLOAD_WARNING or
   // DANGEROUS_DOWNLOAD_BY_API.
   optional bytes token = 15;
 }