testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: address nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 -ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled	1 -ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled

2	2

	3 # NavigationHandle::IsRendererInitiated some times return differently in

	4 # browser side navigation tests.

	5 -SBNavigationObserverBrowserTest.NewTabDownload

	6 -SBNavigationObserverBrowserTest.NewTabDownloadWithDataURL

	7 -SBNavigationObserverBrowserTest.SubFrameNewTabDownload

	8

3 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes	9 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes

4 # returns null for browser-side navigations	10 # returns null for browser-side navigations

5 -PageLoadMetricsBrowserTest.Ignore204Pages	11 -PageLoadMetricsBrowserTest.Ignore204Pages

6 -PageLoadMetricsBrowserTest.IgnoreDownloads	12 -PageLoadMetricsBrowserTest.IgnoreDownloads

7	13

8 # https://crbug.com/650246: ResourcePrefetchPredictor doesn't work correctly yet	14 # https://crbug.com/650246: ResourcePrefetchPredictor doesn't work correctly yet

9 # with PlzNavigate	15 # with PlzNavigate

10 -ResourcePrefetchPredictorBrowserTest.*	16 -ResourcePrefetchPredictorBrowserTest.*

11	17

12 # https://crbug.com/668714: Allow setting net/ flags for NavigationHandle	18 # https://crbug.com/668714: Allow setting net/ flags for NavigationHandle

13 -NoStatePrefetchBrowserTest.PrefetchLoadFlag	19 -NoStatePrefetchBrowserTest.PrefetchLoadFlag

14 -NoStatePrefetchBrowserTest.Prefetch301LoadFlags	20 -NoStatePrefetchBrowserTest.Prefetch301LoadFlags

OLD	NEW