testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter - Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Issue 2538483002: Add management related code to SafeBrowsingNavigationObserverManager (Closed)

Patch Set: address comments from creis@ and holte@ + rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/safe_browsing/download_protection/navigation_observer/landing.html ('K') | « chrome/test/data/safe_browsing/download_protection/navigation_observer/redirect_to_landing.html ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 -ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled	1 -ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled

2 -PDFExtensionTest.PdfAccessibilityInOOPIF	2 -PDFExtensionTest.PdfAccessibilityInOOPIF

3	3

	4 # NavigationHandle::IsRendererInitiated some times return differently in

	5 # browser side navigation tests.

	6 -SBNavigationObserverBrowserTest.NewTabDownload

	7 -SBNavigationObserverBrowserTest.NewTabDownloadWithDataURL

	8 -SBNavigationObserverBrowserTest.SubFrameNewTabDownload

	9

4 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes	10 # https://crbug.com/652767: NavigationHandle::GetResponseHeaders sometimes

5 # returns null for browser-side navigations	11 # returns null for browser-side navigations

6 -PageLoadMetricsBrowserTest.Ignore204Pages	12 -PageLoadMetricsBrowserTest.Ignore204Pages

7 -PageLoadMetricsBrowserTest.IgnoreDownloads	13 -PageLoadMetricsBrowserTest.IgnoreDownloads

8	14

9 # https://crbug.com/650246: ResourcePrefetchPredictor doesn't work correctly yet	15 # https://crbug.com/650246: ResourcePrefetchPredictor doesn't work correctly yet

10 # with PlzNavigate	16 # with PlzNavigate

11 -ResourcePrefetchPredictorBrowserTest.*	17 -ResourcePrefetchPredictorBrowserTest.*

12	18

13 # https://crbug.com/668714: Allow setting net/ flags for NavigationHandle	19 # https://crbug.com/668714: Allow setting net/ flags for NavigationHandle

14 -NoStatePrefetchBrowserTest.PrefetchLoadFlag	20 -NoStatePrefetchBrowserTest.PrefetchLoadFlag

15 -NoStatePrefetchBrowserTest.Prefetch301LoadFlags	21 -NoStatePrefetchBrowserTest.Prefetch301LoadFlags

OLD	NEW