Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2538473004: Revert of After detach, there's no document to notify parsing is finished. (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ ) Reason for revert: Speculative revert for crbug.com/669435 Original issue's description: > After detach, there's no document to notify parsing is finished. > > HTMLViewSourceParser was tripping the DCHECK in > DocumentParser::document when it recieved the last bytes of the > document it was parsing after it was detached. > > BUG=664915 > > Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745 > Cr-Commit-Position: refs/heads/master@{#434937} TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664915 Committed: https://crrev.com/ffe8e7b51df227590c9cadad11dd9e734f571129 Cr-Commit-Position: refs/heads/master@{#434954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLViewSourceDocument.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
battre
Created Revert of After detach, there's no document to notify parsing is finished.
4 years ago (2016-11-29 10:47:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538473004/1
4 years ago (2016-11-29 10:47:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 10:48:36 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ffe8e7b51df227590c9cadad11dd9e734f571129 Cr-Commit-Position: refs/heads/master@{#434954}
4 years ago (2016-11-29 10:51:01 UTC) #7
battre
4 years ago (2016-11-29 13:20:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2535233002/ by battre@chromium.org.

The reason for reverting is: Reland, probably innocuous for crbug.com/669435.

Powered by Google App Engine
This is Rietveld 408576698