Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: content/public/browser/android/app_web_message_port_service.h

Issue 2538463002: android: Don't pass ScopedJavaGlobalRef pointers. (Closed)
Patch Set: timeouts are very annoying Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/android/app_web_message_port_service.h
diff --git a/content/public/browser/android/app_web_message_port_service.h b/content/public/browser/android/app_web_message_port_service.h
index d323ff45651bf22608e087be41b0b889850f17de..c1dd51521f27b20a2e0aed70822b4f58252f1661 100644
--- a/content/public/browser/android/app_web_message_port_service.h
+++ b/content/public/browser/android/app_web_message_port_service.h
@@ -8,6 +8,7 @@
#include <jni.h>
#include <vector>
+#include "base/android/scoped_java_ref.h"
#include "base/values.h"
namespace content {
@@ -18,9 +19,10 @@ class AppWebMessagePortService {
public:
virtual ~AppWebMessagePortService() {}
- virtual void CreateMessageChannel(JNIEnv* env,
- jobjectArray ports,
- WebContents* web_contents) = 0;
+ virtual void CreateMessageChannel(
+ JNIEnv* env,
+ const base::android::JavaRef<jobjectArray>& ports,
+ WebContents* web_contents) = 0;
virtual void CleanupPort(int message_port_id) = 0;
};
« no previous file with comments | « content/browser/web_contents/web_contents_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698