Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: content/browser/android/app_web_message_port_service_impl.h

Issue 2538463002: android: Don't pass ScopedJavaGlobalRef pointers. (Closed)
Patch Set: timeouts are very annoying Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/app_web_message_port_service_impl.h
diff --git a/content/browser/android/app_web_message_port_service_impl.h b/content/browser/android/app_web_message_port_service_impl.h
index e43785ba423c14884976901ae07bb47dddc3f12a..84c72eafcd05a4911478805051de4d41337467ee 100644
--- a/content/browser/android/app_web_message_port_service_impl.h
+++ b/content/browser/android/app_web_message_port_service_impl.h
@@ -34,7 +34,7 @@ class AppWebMessagePortServiceImpl : public AppWebMessagePortService {
// AppWebMessagePortService implementation
void CreateMessageChannel(JNIEnv* env,
- jobjectArray ports,
+ const base::android::JavaRef<jobjectArray>& ports,
WebContents* web_contents) override;
void CleanupPort(int message_port_id) override;
@@ -73,7 +73,7 @@ class AppWebMessagePortServiceImpl : public AppWebMessagePortService {
int* port1,
int* port2);
void OnMessageChannelCreated(
- base::android::ScopedJavaGlobalRef<jobjectArray>* ports,
+ const base::android::JavaRef<jobjectArray>& ports,
int* port1,
int* port2);
void AddPort(int message_port_id, AppWebMessagePortMessageFilter* filter);

Powered by Google App Engine
This is Rietveld 408576698