android: Don't pass ScopedJavaGlobalRef pointers.

chrome/browser/android/favicon_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/favicon_helper.h"
 
 #include <jni.h>
 #include <stddef.h>
 
 #include <vector>
@@ skipping 18 matching lines @@
 #include "jni/FaviconHelper_jni.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/color_analysis.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_rep.h"
 
 using base::android::JavaParamRef;
+using base::android::JavaRef;
 using base::android::ScopedJavaGlobalRef;
 using base::android::ScopedJavaLocalRef;
 using base::android::AttachCurrentThread;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 
 namespace {
 
 void OnLocalFaviconAvailable(
-    ScopedJavaGlobalRef<jobject>* j_favicon_image_callback,
+    const JavaRef<jobject>& j_favicon_image_callback,
     const favicon_base::FaviconRawBitmapResult& result) {
   JNIEnv* env = AttachCurrentThread();
 
   // Convert favicon_image_result to java objects.
   ScopedJavaLocalRef<jstring> j_icon_url =
       ConvertUTF8ToJavaString(env, result.icon_url.spec());
   ScopedJavaLocalRef<jobject> j_favicon_bitmap;
   if (result.is_valid()) {
     SkBitmap favicon_bitmap;
     gfx::PNGCodec::Decode(result.bitmap_data->front(),
                           result.bitmap_data->size(),
                           &favicon_bitmap);
     if (!favicon_bitmap.isNull())
       j_favicon_bitmap = gfx::ConvertToJavaBitmap(&favicon_bitmap);
   }
 
   // Call java side OnLocalFaviconAvailable method.
-  Java_FaviconImageCallback_onFaviconAvailable(
-      env, j_favicon_image_callback->obj(), j_favicon_bitmap, j_icon_url);
+  Java_FaviconImageCallback_onFaviconAvailable(env, j_favicon_image_callback,
+                                               j_favicon_bitmap, j_icon_url);
 }
 
 size_t GetLargestSizeIndex(const std::vector<gfx::Size>& sizes) {
   DCHECK(!sizes.empty());
   size_t ret = 0;
   for (size_t i = 1; i < sizes.size(); ++i) {
     if (sizes[ret].GetArea() < sizes[i].GetArea())
       ret = i;
   }
   return ret;
@@ skipping 79 matching lines @@
   if (!profile)
     return false;
 
   favicon::FaviconService* favicon_service =
       FaviconServiceFactory::GetForProfile(profile,
                                            ServiceAccessType::EXPLICIT_ACCESS);
   DCHECK(favicon_service);
   if (!favicon_service)
     return false;
 
-  ScopedJavaGlobalRef<jobject>* j_scoped_favicon_callback =
-      new ScopedJavaGlobalRef<jobject>();
-  j_scoped_favicon_callback->Reset(env, j_favicon_image_callback);
-
-  favicon_base::FaviconRawBitmapCallback callback_runner = base::Bind(
-      &OnLocalFaviconAvailable, base::Owned(j_scoped_favicon_callback));
+  favicon_base::FaviconRawBitmapCallback callback_runner =
+      base::Bind(&OnLocalFaviconAvailable,
+                 ScopedJavaGlobalRef<jobject>(j_favicon_image_callback));
 
   favicon_service->GetRawFaviconForPageURL(
       GURL(ConvertJavaStringToUTF16(env, j_page_url)),
       static_cast<int>(j_icon_types),
       static_cast<int>(j_desired_size_in_pixel),
       callback_runner,
       cancelable_task_tracker_.get());
 
   return true;
 }
@@ skipping 74 matching lines @@
 
   gfx::JavaBitmap bitmap_lock(bitmap);
   SkBitmap skbitmap = gfx::CreateSkBitmapFromJavaBitmap(bitmap_lock);
   return color_utils::CalculateKMeanColorOfBitmap(skbitmap);
 }
 
 // static
 bool FaviconHelper::RegisterFaviconHelper(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }