Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 253843008: Remove v8 gn config from secondary tree (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Remove v8 gn config from secondary tree We'll important the BUILD.gn into v8 instead to make maintaining it easier BUG=none R=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -709 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D tools/gn/secondary/v8/BUILD.gn View 1 chunk +0 lines, -708 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-04-29 14:36:06 UTC) #1
brettw
lgtm
6 years, 7 months ago (2014-04-29 21:38:53 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-04-30 17:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/253843008/1
6 years, 7 months ago (2014-04-30 17:05:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 18:12:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 18:12:58 UTC) #6
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-05 12:39:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/253843008/1
6 years, 7 months ago (2014-05-05 12:39:24 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 13:31:42 UTC) #9
Message was sent while issue was closed.
Change committed as 268170

Powered by Google App Engine
This is Rietveld 408576698