Issue 253843006: Object::Lookup(), JSObject::*Lookup*() and JSReceiver::*Lookup*() handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 253843006: Object::Lookup(), JSObject::Lookup() and JSReceiver::Lookup() handlified. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Object::Lookup(), JSObject::*Lookup*() and JSReceiver::*Lookup*() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21051

Patch Set 2 : Addressing review comments #

Created: 6 years, 7 months ago

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -103 lines)
M	src/api.cc	View	3 chunks	+3 lines, -3 lines	0 comments
M	src/bootstrapper.cc	View	4 chunks	+7 lines, -7 lines	0 comments
M	src/heap-snapshot-generator.cc	View	1 chunk	+4 lines, -2 lines	0 comments
M	src/hydrogen.cc	View	3 chunks	+3 lines, -3 lines	0 comments
M	src/ic.cc	View	5 chunks	+6 lines, -6 lines	0 comments
M	src/json-stringifier.h	View	1 chunk	+1 line, -1 line	0 comments
M	src/objects.h	View	4 chunks	+8 lines, -10 lines	0 comments
M	src/objects.cc	View	41 chunks	+55 lines, -57 lines	0 comments
M	src/runtime.cc	View	12 chunks	+12 lines, -12 lines	0 comments
M	src/stub-cache.cc	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with a nit https://codereview.chromium.org/253843006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/253843006/diff/1/src/objects.cc#newcode3560 src/objects.cc:3560: pt != *null_value; I think ...

6 years, 7 months ago (2014-04-29 13:26:02 UTC) #2

Igor Sheludko

https://codereview.chromium.org/253843006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/253843006/diff/1/src/objects.cc#newcode3560 src/objects.cc:3560: pt != *null_value; On 2014/04/29 13:26:02, Yang wrote: > ...

6 years, 7 months ago (2014-04-29 13:35:20 UTC) #3

Igor Sheludko

6 years, 7 months ago (2014-04-29 13:43:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21051 (presubmit successful).

Expand Messages | Collapse Messages

Issue 253843006: Object::Lookup(), JSObject::*Lookup*() and JSReceiver::*Lookup*() handlified. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing review comments #

Messages

Issue 253843006: Object::Lookup(), JSObject::Lookup() and JSReceiver::Lookup() handlified. (Closed)