Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253843005: Fix mojo startup (Closed)

Created:
6 years, 7 months ago by darin (slow to review)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Fix mojo startup Defer until both OnProcessLaunched and ConnectTo have been called. BUG=366644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267104

Patch Set 1 #

Patch Set 2 : re-enable tests on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +21 lines, -9 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
LGTM
6 years, 7 months ago (2014-04-29 14:58:42 UTC) #1
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-04-29 18:58:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/253843005/20001
6 years, 7 months ago (2014-04-29 19:01:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 19:45:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 19:45:37 UTC) #5
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-04-30 03:51:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/253843005/20001
6 years, 7 months ago (2014-04-30 03:53:21 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 06:52:17 UTC) #8
Message was sent while issue was closed. 
Change committed as 267104

Powered by Google App Engine
This is Rietveld 408576698