Reload Reloaded: Use ReloadMainResource even on recovering from offline

Reload Reloaded: Use ReloadMainResource even on recovering from offline

blink::WebFrameLoadType::Reload re-validates all resources, but
blink::WebFrameLoadType::ReloadMainResource only re-validates
the main document. Recently NavigationController was modified
to use ReloadMainResource instead of Reload.

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
Reload. Let replace it with ReloadMainResource as we did for reloads
through the NavigationController.

BUG=669580
Committed: https://crrev.com/e702f8d9772ebd56c5a75186841d98222861dae3
Cr-Commit-Position: refs/heads/master@{#435886}

[Takashi Toyoshima, 2016-12-01 09:24:16]

Description was changed from

==========
Reload Reloaded: Use faster reload even on recovering from offline

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
blink::WebFrameLoadType::Reload. Let replace it with ReloadMainResource
as we did for reloads through the NavigationController.

BUG=669580
==========

to

==========
Reload Reloaded: Use faster reload even on recovering from offline

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
blink::WebFrameLoadType::Reload. Let replace it with ReloadMainResource
as we did for reloads through the NavigationController.

BUG=669580
==========

[Takashi Toyoshima, 2016-12-01 09:24:16]

toyoshim@chromium.org changed reviewers:
+ mmenke@chromium.org

[Takashi Toyoshima, 2016-12-01 09:25:08]

toyoshim@chromium.org changed reviewers:
+ dcheng@chromium.org

[Takashi Toyoshima, 2016-12-01 09:25:14]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 09:25:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-01 11:04:19]

mmenke: chrome/renderer/net
dcheng: Blink

Can you take a look?

[commit-bot: I haz the power, 2016-12-01 11:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 11:47:47]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-12-01 15:29:34]

On 2016/12/01 11:04:19, toyoshim wrote:
> mmenke: chrome/renderer/net
> dcheng: Blink
> 
> Can you take a look?

LGTM, but would you update the description?  "faster reload" isn't clear.  Maybe
"reload that only re-validates the main document", assuming that's what the
description means.

[dcheng, 2016-12-01 22:13:24]

blink LGTM

[Takashi Toyoshima, 2016-12-02 08:14:01]

Description was changed from

==========
Reload Reloaded: Use faster reload even on recovering from offline

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
blink::WebFrameLoadType::Reload. Let replace it with ReloadMainResource
as we did for reloads through the NavigationController.

BUG=669580
==========

to

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
blink::WebFrameLoadType::Reload. Let replace it with ReloadMainResource
as we did for reloads through the NavigationController.

Reload re-validates all resources, but ReloadMainResource only
re-validates the main document.

BUG=669580
==========

[Takashi Toyoshima, 2016-12-02 08:16:18]

Description was changed from

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
blink::WebFrameLoadType::Reload. Let replace it with ReloadMainResource
as we did for reloads through the NavigationController.

Reload re-validates all resources, but ReloadMainResource only
re-validates the main document.

BUG=669580
==========

to

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

blink::WebFrameLoadType::Reload re-validates all resources, but
blink::WebFrameLoadType::ReloadMainResource only re-validates
the main document. Recently NavigationController was modified
to use ReloadMainResource instead of Reload.

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
Reload. Let replace it with ReloadMainResource as we did for reloads
through the NavigationController.

BUG=669580
==========

[Takashi Toyoshima, 2016-12-02 08:16:22]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-12-02 08:16:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 08:23:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480666582677350, "parent_rev":
"ebd423ab9241f87f8c9ada590997b39be949b1fd", "commit_rev":
"c17721bc120a6e43f7ba3563fe5366e91af97cfd"}

[commit-bot: I haz the power, 2016-12-02 08:23:59]

Description was changed from

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

blink::WebFrameLoadType::Reload re-validates all resources, but
blink::WebFrameLoadType::ReloadMainResource only re-validates
the main document. Recently NavigationController was modified
to use ReloadMainResource instead of Reload.

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
Reload. Let replace it with ReloadMainResource as we did for reloads
through the NavigationController.

BUG=669580
==========

to

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

blink::WebFrameLoadType::Reload re-validates all resources, but
blink::WebFrameLoadType::ReloadMainResource only re-validates
the main document. Recently NavigationController was modified
to use ReloadMainResource instead of Reload.

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
Reload. Let replace it with ReloadMainResource as we did for reloads
through the NavigationController.

BUG=669580
==========

[commit-bot: I haz the power, 2016-12-02 08:24:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-02 08:25:46]

Description was changed from

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

blink::WebFrameLoadType::Reload re-validates all resources, but
blink::WebFrameLoadType::ReloadMainResource only re-validates
the main document. Recently NavigationController was modified
to use ReloadMainResource instead of Reload.

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
Reload. Let replace it with ReloadMainResource as we did for reloads
through the NavigationController.

BUG=669580
==========

to

==========
Reload Reloaded: Use ReloadMainResource even on recovering from offline

blink::WebFrameLoadType::Reload re-validates all resources, but
blink::WebFrameLoadType::ReloadMainResource only re-validates
the main document. Recently NavigationController was modified
to use ReloadMainResource instead of Reload.

When chrome is offline, NetErrorHelper monitors network state,
and reload a page when it gets online.
Since NetErrorHelper does not use NavigationController, but calls
WebFrame::reload() interface, it still uses traditional reload type,
Reload. Let replace it with ReloadMainResource as we did for reloads
through the NavigationController.

BUG=669580

Committed: https://crrev.com/e702f8d9772ebd56c5a75186841d98222861dae3
Cr-Commit-Position: refs/heads/master@{#435886}
==========

[commit-bot: I haz the power, 2016-12-02 08:25:47]

Patchset 1 (id:??) landed as
https://crrev.com/e702f8d9772ebd56c5a75186841d98222861dae3
Cr-Commit-Position: refs/heads/master@{#435886}