Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2538413002:
Postpone automatic popup of cloud backup details until ready to backup. (Closed)
|
Created:
4 years ago by yamaguchi Modified:
4 years ago Reviewers:
fukino CC:
chromium-reviews, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, fukino+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPostpone automatic popup of cloud backup details until ready to backup.
BUG=669745
TEST=manual test as noted in the bug.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/60f4f97afbc985bfedb7c119d00932c326db9d4f
Cr-Commit-Position: refs/heads/master@{#436236}
Patch Set 1 #Patch Set 2 : Update import controller unittest to reflect UI flow change. #
Messages
Total messages: 25 (18 generated)
Description was changed from ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 ========== to ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test. Plus an SD card with several unimported photos, confirm the details box doesn't open automatically before scan ends. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test. Plus an SD card with several unimported photos, confirm the details box doesn't open automatically before scan ends. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
yamaguchi@chromium.org changed reviewers: + fukino@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
yamaguchi@chromium.org changed reviewers: - fukino@chromium.org
Need to update unit tests in: ui/file_manager/file_manager/foreground/js/import_controller_unittest.js
The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yamaguchi@chromium.org changed reviewers: + fukino@chromium.org
Updated the test. PTAL.
lgtm
The CQ bit was checked by yamaguchi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480917389180160,
"parent_rev": "7de1581afaa365ef604277bc5c6c068353e74bad", "commit_rev":
"38ab3b6e2464c77908fbefed4485e278a49795f5"}
Message was sent while issue was closed.
Description was changed from ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Postpone automatic popup of cloud backup details until ready to backup. BUG=669745 TEST=manual test as noted in the bug. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/60f4f97afbc985bfedb7c119d00932c326db9d4f Cr-Commit-Position: refs/heads/master@{#436236} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/60f4f97afbc985bfedb7c119d00932c326db9d4f Cr-Commit-Position: refs/heads/master@{#436236} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
