Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(111)

Issue 2538403002: Revert of binding: Removes Document::wrap that must be equivalent to Node::wrap. (Closed)

Created:
3 years, 11 months ago by Yuki
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of binding: Removes Document::wrap that must be equivalent to Node::wrap. (patchset #5 id:100001 of https://codereview.chromium.org/2525313004/ ) Reason for revert: CHECK(!frame->document()->containsWrapper()); in WindowProxy::updateDocumentProperty() is causing crashes at several places. Original issue's description: > binding: Removes Document::wrap that must be equivalent to Node::wrap. > > Removes unnecessary Document::wrap and associateWithWrapper. > The special code in these functions were made in order to keep > WindowProxy::m_document updated and consistent with toV8(document). > But we no longer rely on the hack, and we can remove the dead code. > > BUG= > > Committed: https://crrev.com/87dc599743f71d33466ac56a8db5a53c5f6ce46c > Cr-Commit-Position: refs/heads/master@{#435226} TBR=haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669968 Committed: https://crrev.com/37245cec49bc7e8f36bbfa160ec7599f88b2040e Cr-Commit-Position: refs/heads/master@{#435565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -35 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 6 chunks +39 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Yuki
Created Revert of binding: Removes Document::wrap that must be equivalent to Node::wrap.
3 years, 11 months ago (2016-12-01 06:27:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538403002/1
3 years, 11 months ago (2016-12-01 06:28:13 UTC) #3
haraken
LGTM
3 years, 11 months ago (2016-12-01 06:28:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-01 06:29:08 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-01 06:34:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37245cec49bc7e8f36bbfa160ec7599f88b2040e
Cr-Commit-Position: refs/heads/master@{#435565}

Powered by Google App Engine
This is Rietveld 408576698