Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2538393002: MD Settings: fix /importData dialog's back/forward navigation (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, tfarina, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix /importData dialog's back/forward navigation "Just ignore popstate events. I got this." - route.js R=tommycli@chromium.org BUG=668004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f9e7a101651feb98b6b05d3216c785cfb5175719 Cr-Commit-Position: refs/heads/master@{#435644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/people_page/import_data_dialog.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Dan Beam
4 years ago (2016-12-01 05:54:46 UTC) #3
tommycli
lgtm
4 years ago (2016-12-01 16:27:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538393002/1
4 years ago (2016-12-01 17:44:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 17:48:38 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 17:52:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9e7a101651feb98b6b05d3216c785cfb5175719
Cr-Commit-Position: refs/heads/master@{#435644}

Powered by Google App Engine
This is Rietveld 408576698