Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chrome/browser/ui/cocoa/external_protocol_dialog.mm

Issue 2538353002: fix external protocol handling for OOPIFs (Closed)
Patch Set: remove unnecessary include Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/external_protocol_dialog.mm
diff --git a/chrome/browser/ui/cocoa/external_protocol_dialog.mm b/chrome/browser/ui/cocoa/external_protocol_dialog.mm
index baafbbebe2fed1cd518e84f6c78db5c5a4ecb9b9..73781e0fd61e046eb0e25fbd60b2d7498d690f44 100644
--- a/chrome/browser/ui/cocoa/external_protocol_dialog.mm
+++ b/chrome/browser/ui/cocoa/external_protocol_dialog.mm
@@ -8,6 +8,7 @@
#include "base/metrics/histogram_macros.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
#include "components/strings/grit/components_strings.h"
@@ -117,8 +118,10 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(
UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
base::Time::Now() - creation_time_);
- ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(
- url_, render_process_host_id_, routing_id_);
+ content::WebContents* web_contents =
+ tab_util::GetWebContentsByID(render_process_host_id_, routing_id_);
+
+ ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(url_, web_contents);
}
[self autorelease];
« no previous file with comments | « chrome/browser/prerender/prerender_test_utils.cc ('k') | chrome/browser/ui/external_protocol_dialog_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698